Merge lp://qastaging/~elopio/snapcraft/log_handler-2 into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Leo Arias
Status: | Needs review |
---|---|
Proposed branch: | lp://qastaging/~elopio/snapcraft/log_handler-2 |
Merge into: | lp://qastaging/~snappy-dev/snapcraft/core |
Prerequisite: | lp://qastaging/~elopio/snapcraft/log_handler |
Diff against target: |
105 lines (+42/-9) 4 files modified
snapcraft/cmds.py (+1/-3) snapcraft/log.py (+26/-5) snapcraft/tests/test_cmds.py (+2/-1) snapcraft/tests/test_log.py (+13/-0) |
To merge this branch: | bzr merge lp://qastaging/~elopio/snapcraft/log_handler-2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Snappy Developers | Pending | ||
Review via email: mp+266481@code.qastaging.launchpad.net |
Commit message
Added filters to better handle the bold in the log.
Description of the change
Here again I went the extra mile to keep the existing behaviour. But this stuff opens the way to fancier and consistent logging, so we can change it whenever we like.
To post a comment you must log in.
This handles the specific case of the "Wrote the following as snapcraft.yaml:" message. But it feels a bit too magic to me. Doesn't it feel weird to automatically bold things based on whether a colon-newline appears in the string?
This also doesn't address the other print() statements (like when we run a subcommand.
Wouldn't it make more sense to have an argument to the info() call (maybe provided by a subclassed Logger class from snapcraft.log)?