Merge lp://qastaging/~elopio/snapcraft/log_handler into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Leo Arias
| Status: | Merged |
|---|---|
| Approved by: | Michael Terry |
| Approved revision: | 115 |
| Merged at revision: | 116 |
| Proposed branch: | lp://qastaging/~elopio/snapcraft/log_handler |
| Merge into: | lp://qastaging/~snappy-dev/snapcraft/core |
| Diff against target: |
174 lines (+140/-8) 3 files modified
snapcraft/log.py (+52/-0) snapcraft/main.py (+2/-8) snapcraft/tests/test_log.py (+86/-0) |
| To merge this branch: | bzr merge lp://qastaging/~elopio/snapcraft/log_handler |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Terry (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Send error logs to stderr and message logs to stdout.
Description of the change
On the original logging prints, some messages went to stdout and some to stderr. That was not consistent, nor tested. So this branch adds two handlers to recover that behavoiur, but cleaner.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM, thanks Leo! And nice that we have a separate log module for any future additions.