Snapcraft

Merge lp://qastaging/~elopio/snapcraft/symlinks-2 into lp://qastaging/~snappy-dev/snapcraft/core

  1. symlinks-2
  2. Merge into core
Proposed by Leo Arias
Status: Rejected
Rejected by: Leo Arias
Proposed branch: lp://qastaging/~elopio/snapcraft/symlinks-2
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Prerequisite: lp://qastaging/~elopio/snapcraft/symlinks
Diff against target: 18 lines (+4/-2)
1 file modified
snapcraft/tests/test_ubuntu_plugin.py (+4/-2)
To merge this branch: bzr merge lp://qastaging/~elopio/snapcraft/symlinks-2
Reviewer Review Type Date Requested Status
Leo Arias (community) Disapprove
Review via email: mp+267240@code.qastaging.launchpad.net

Commit message

Fixed the symlinks tests to check dir links.

To post a comment you must log in.
lp://qastaging/~elopio/snapcraft/symlinks-2 updated
134. By Leo Arias

Cleaned the test.

Revision history for this message
Leo Arias (elopio) wrote :

From sergion on the prerequisite:

I'm going to reject this as it is no longer as relevant with filesets.

review: Disapprove

Unmerged revisions

134. By Leo Arias

Cleaned the test.

133. By Leo Arias

Fixed the symlinks tests to check dir links.

132. By Leo Arias

Merged with parent.

131. By Leo Arias

Use scenarios for symlinks.

130. By Leo Arias

Joined the ubuntu plugin unit tests.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: