Merge lp://qastaging/~elopio/snapcraft/symlinks into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Leo Arias
| Status: | Rejected |
|---|---|
| Rejected by: | Sergio Schvezov |
| Proposed branch: | lp://qastaging/~elopio/snapcraft/symlinks |
| Merge into: | lp://qastaging/~snappy-dev/snapcraft/core |
| Diff against target: |
164 lines (+67/-63) 2 files modified
snapcraft/plugins/tests/test_ubuntu.py (+0/-61) snapcraft/tests/test_ubuntu_plugin.py (+67/-2) |
| To merge this branch: | bzr merge lp://qastaging/~elopio/snapcraft/symlinks |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sergio Schvezov | Disapprove | ||
|
Review via email:
|
|||
Commit message
Joined the ubuntu plugin unit tests.
Description of the change
I found another ubuntu plugin tests file. IMO, it's better to keep all the tests in the same directory, so I moved them to snapcraft/tests. If we add many tests for plugins, we can make a directory snapcraft/
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I'm going to reject this as it is no longer as relevant with filesets.