Merge lp://qastaging/~elopio/ubuntu-autopilot-tests/content-hub-address-book into lp://qastaging/ubuntu-autopilot-tests/ubuntu-experience-tests

Proposed by Leo Arias
Status: Rejected
Rejected by: Leo Arias
Proposed branch: lp://qastaging/~elopio/ubuntu-autopilot-tests/content-hub-address-book
Merge into: lp://qastaging/ubuntu-autopilot-tests/ubuntu-experience-tests
Diff against target: 74 lines (+58/-0)
2 files modified
debian/control (+4/-0)
ubuntu_experience_tests/tests/contenthub/test_address_book_integration_with_content_hub.py (+54/-0)
To merge this branch: bzr merge lp://qastaging/~elopio/ubuntu-autopilot-tests/content-hub-address-book
Reviewer Review Type Date Requested Status
Julien Funk Pending
Víctor R. Ruiz Pending
Javier Collado Pending
Richard Huddie Pending
Ubuntu Testcase Admins Pending
Review via email: mp+206111@code.qastaging.launchpad.net

Description of the change

This is a skeleton for a user acceptance test of an Ubuntu Experience.

Every step on the test is a helper that needs to be implemented and tested on the corresponding project.

So, for example, address_book.main_window.go_to_add_contact() needs to be written in http://bazaar.launchpad.net/~phablet-team/address-book-app/trunk/view/head:/tests/autopilot/address_book_app/emulators/main_window.py

Jvier, Richard and Victor, my proposal for the work of what remains of this week and the next one is that each one of us takes a line from this skeleton and implements that helper.

I'll ping you when I wake up so we can discuss about this, and you can tell me what do you think.

Please not that the gaps team is working on the address book, so we'll need to coordinate work with them.

Also, we'll find automation blockers on our way, but that's precisely the purpose of this. Start a test from top to bottom, with the highest level definition, and start implementing step by step, solving blockers on our way. If we can't solve a blocker without a developer help, we can jump to the next step or the next test while it's being fixed.

To post a comment you must log in.
13. By Leo Arias

Added the depenencies.

14. By Leo Arias

Rename.

Revision history for this message
Leo Arias (elopio) wrote :

63 + address_book = self.open_address_book() -> Javier will do it.
64 + contact_editor = address_book.main_window.go_to_add_contact() -> Richard will do it.
65 + contact_editor.fill_form(first_name=test_first_name) -> Leo will do it.

Revision history for this message
Víctor R. Ruiz (vrruiz) wrote :

All classes and functions should have a docstring that briefly describes them.

44 + class AddressBookIntegrationWithGalleryTestCase(tests.IntegrationTestCase):
45 + """ Test the address book with the gallery app """

54 + def get_gallery_app_proxy_object(self):
55 + """ Returns the proxy object of the Gallery App """

If a test goes through some steps, add some comments in the code. This helps others developers to understand the code. Although code should be self-explanatory, some docstrings are even better.

etc.

15. By Leo Arias

Merged with trunk.

Revision history for this message
Leo Arias (elopio) wrote :

Rejecting because Richard took over this branch.

Unmerged revisions

15. By Leo Arias

Merged with trunk.

14. By Leo Arias

Rename.

13. By Leo Arias

Added the depenencies.

12. By Leo Arias

Top-down test skeleton for test_add_contanct_with_picture_must_display_it_in_contact_list.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches