Merge lp://qastaging/~elopio/ubuntu-autopilot-tests/url_dispatcher into lp://qastaging/ubuntu-autopilot-tests/ubuntu-experience-tests

Proposed by Leo Arias
Status: Merged
Approved by: Leo Arias
Approved revision: 22
Merged at revision: 19
Proposed branch: lp://qastaging/~elopio/ubuntu-autopilot-tests/url_dispatcher
Merge into: lp://qastaging/ubuntu-autopilot-tests/ubuntu-experience-tests
Diff against target: 111 lines (+65/-4)
4 files modified
debian/control (+1/-0)
ubuntu_experience_tests/tests/__init__.py (+6/-2)
ubuntu_experience_tests/tests/application_life_cycle/test_url_dispatcher.py (+57/-0)
ubuntu_experience_tests/tests/test_osd_dialer_integration.py (+1/-2)
To merge this branch: bzr merge lp://qastaging/~elopio/ubuntu-autopilot-tests/url_dispatcher
Reviewer Review Type Date Requested Status
Chris Gagnon (community) Approve
Review via email: mp+208616@code.qastaging.launchpad.net

Commit message

Test that online accounts launched with url dispatcher can be swiped into background.

To post a comment you must log in.
21. By Leo Arias

Added a docstring.

Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

This would be better in a custom proxy object or it it's own click_accept_button method

+ accept_button = self._get_accept_button(self.unity_proxy)
110
111 self.pointing_device.click_object(accept_button)

review: Needs Fixing
22. By Leo Arias

Remove the apostrophe.

Revision history for this message
Chris Gagnon (chris.gagnon) :
review: Approve
Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

I didn't look closely enough at the code, it's already in a method... lgtm

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches