Unity 8

Merge lp://qastaging/~elopio/unity8/flake8 into lp://qastaging/unity8

flake8
Merge into trunk

Proposed by Leo Arias on 2014-06-18

Status:	Merged
Approved by:	Michał Sawicz on 2014-06-27
Approved revision:	978
Merged at revision:	1001
Proposed branch:	lp://qastaging/~elopio/unity8/flake8
Merge into:	lp://qastaging/unity8
Diff against target:	561 lines (+137/-72) 10 files modified .bazaar/plugins/makecheck_unity_phablet.py (+17/-9) tests/autopilot/unity8/process_helpers.py (+4/-3) tests/autopilot/unity8/shell/tests/__init__.py (+1/-2) tests/autopilot/unity8/shell/tests/disabled_test_hud.py (+44/-13) tests/autopilot/unity8/shell/tests/test_emulators.py (+0/-2) tests/autopilot/unity8/shell/tests/test_lock_screen.py (+4/-5) tests/autopilot/unity8/shell/tests/test_notifications.py (+15/-10) tests/autopilot/unity8/shell/tests/test_system_integration.py (+10/-5) tests/autopilot/unity8/shell/tests/test_upstart.py (+20/-11) tests/whitespace/check_whitespace.py (+22/-12)
To merge this branch:	bzr merge lp://qastaging/~elopio/unity8/flake8
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Needs Fixing on 2014-06-27
Michał Sawicz		2014-06-18	Approve on 2014-06-27
Review via email: mp+223495@code.qastaging.launchpad.net

Commit message

Fixed style and static python errors.

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.

No related MPs.

* Did you perform an exploratory manual test run of your code change and any related functionality?

More or less. I ran all the tests to confirm they kept working.

* Did you make sure that your branch does not contain spurious tags?

Yes I did.

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

No packaging changes.

* If you changed the UI, has there been a design review?

No UI changes.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-18:

PASSED: Continuous integration, rev:974
http://jenkins.qa.ubuntu.com/job/unity8-ci/3165/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/976
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/169
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/259
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/259
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/259/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/259
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1363
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1739
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1739/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/8560

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3165/rebuild

review: Approve (continuous-integration)

lp://qastaging/~elopio/unity8/flake8 updated on 2014-06-25

975. By Leo Arias on 2014-06-25: Merged with trunk.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-25:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3221/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-06-26:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3227/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Michał Sawicz (saviq) wrote on 2014-06-27:

I'm still getting:
$ flake8 tests/
tests/autopilot/unity8/process_helpers.py:176:8: E713 test for membership should be 'not in'
tests/autopilot/unity8/shell/tests/__init__.py:145:9: E265 block comment should start with '# '
tests/whitespace/check_whitespace.py:42:60: E901 SyntaxError: invalid syntax

Should we add flake8 as a test?

=== modified file 'tests/CMakeLists.txt'
--- tests/CMakeLists.txt 2014-05-30 09:21:39 +0000
+++ tests/CMakeLists.txt 2014-06-27 07:29:39 +0000
@@ -13,3 +13,5 @@
add_subdirectory(plugins)
add_subdirectory(utils)
add_subdirectory(uqmlscene)
+
+add_test(flake8 flake8 ${CMAKE_CURRENT_SOURCE_DIR})