Code review comment for lp://qastaging/~epics-core/epics-base/rsrvbindiface

Revision history for this message
Andrew Johnson (anj) wrote :

> So clearly __CYGWIN32__ is not the right macro to test.

We define our own flags for most architectures, please look for and use those instead of trying to guess what the compiler might define:

tux% cd configure/os
tux% grep OP_SYS_CPPFLAGS *
CONFIG.Common.cygwin-x86:OP_SYS_CPPFLAGS += -DCYGWIN32
CONFIG.Common.freebsdCommon:OP_SYS_CPPFLAGS += -D_BSD_SOURCE
CONFIG.Common.freebsdCommon:OP_SYS_CPPFLAGS += -Dfreebsd
CONFIG.Common.linuxCommon:OP_SYS_CPPFLAGS += -Dlinux
CONFIG.Common.RTEMS: $(USR_CPPFLAGS) $(CMD_CPPFLAGS) $(ARCH_DEP_CPPFLAGS) $(OP_SYS_CPPFLAGS)\
CONFIG.Common.solaris-sparc:OP_SYS_CPPFLAGS += -DSOLARIS=$(SOLARIS_VERSION) $(COMPILER_CPPFLAGS)
CONFIG.Common.solaris-x86:OP_SYS_CPPFLAGS += -DSOLARIS=$(SOLARIS_VERSION) $(COMPILER_CPPFLAGS)
CONFIG.Common.UnixCommon:OP_SYS_CPPFLAGS += -DUNIX
CONFIG.Common.vxWorksCommon:OP_SYS_CPPFLAGS += -DvxWorks=vxWorks
CONFIG.Common.win32-x86-mingw:OP_SYS_CPPFLAGS = -D_MINGW
CONFIG.darwinCommon.darwinCommon:OP_SYS_CPPFLAGS += -Ddarwin

« Back to merge proposal