Merge lp://qastaging/~erasmo-marin/foto/fix-import into lp://qastaging/foto/foto-1.0
Proposed by
Erasmo Marín
| Status: | Merged |
|---|---|
| Approved by: | Erasmo Marín |
| Approved revision: | 113 |
| Merged at revision: | 118 |
| Proposed branch: | lp://qastaging/~erasmo-marin/foto/fix-import |
| Merge into: | lp://qastaging/foto/foto-1.0 |
| Diff against target: |
437 lines (+220/-78) 9 files modified
CMakeLists.txt (+2/-0) src/FotoApp.vala (+8/-5) src/ViewManager.vala (+2/-1) src/core/ImportJob.vala (+41/-62) src/core/Threads/Threads.vala (+145/-0) src/pages/AlbumPage.vala (+1/-1) src/pages/CollectionPage.vala (+0/-1) src/pages/LastImportedPage.vala (+19/-6) src/pages/WelcomePage.vala (+2/-2) |
| To merge this branch: | bzr merge lp://qastaging/~erasmo-marin/foto/fix-import |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Fabio Zaramella | Approve | ||
|
Review via email:
|
|||
Description of the change
-Adds Threads.vala taken from lp:noise, it creates a ThreadPool for thread management.
-Adds a workaround (not sure if this is a definitive solution) to fix the import crash when the thread ends by adding X.init_threads() in main.
-Adds a method to refresh the import page.
With the new Threads class, it will be easier to implement IO operations without blocking GUI.
To post a comment you must log in.
Revision history for this message
| Fabio Zaramella (fabiozaramella) wrote | # |
Revision history for this message
| Erasmo Marín (erasmo-marin) wrote | # |
Revision history for this message
| Fabio Zaramella (fabiozaramella) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks and works great, no more crashes.