Landscape Charm

Merge lp://qastaging/~ericsnowcurrently/landscape-charm/tools-unit-tests-for-script into lp://qastaging/~landscape/landscape-charm/tools

Proposed by Eric Snow on 2016-08-16

Status:	Merged
Approved by:	Eric Snow on 2016-08-19
Approved revision:	28
Merged at revision:	23
Proposed branch:	lp://qastaging/~ericsnowcurrently/landscape-charm/tools-unit-tests-for-script
Merge into:	lp://qastaging/~landscape/landscape-charm/tools
Diff against target:	1130 lines (+910/-78) 2 files modified collect-logs (+161/-78) test_collect-logs.py (+749/-0)
To merge this branch:	bzr merge lp://qastaging/~ericsnowcurrently/landscape-charm/tools-unit-tests-for-script
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Chad Smith	2016-08-16	Approve on 2016-08-19
Benji York (community)	2016-08-16	Approve on 2016-08-18
Review via email: mp+303061@code.qastaging.launchpad.net

Add unit tests for the collect-logs script.

Add unit tests for the collect-logs script.

Testing instructions:

Run the tests with "python -m unittest test_collect-logs".

Revision history for this message

Benji York (benji) wrote on 2016-08-18:

Assuming the inline comments are addressed, this branch looks good to me.

review: Approve

Revision history for this message

Chad Smith (chad.smith) wrote on 2016-08-19:

+1 plus the fix we talked about in irc to avoid hitting an external "real" juju when running execfile
https://pastebin.canonical.com/163587/

review: Approve

Revision history for this message

Eric Snow (ericsnowcurrently) on 2016-08-19:

22. By Eric Snow on 2016-08-19: Do not call juju_status() as a default keyword argument.
23. By Eric Snow on 2016-08-19: typo
24. By Eric Snow on 2016-08-19: _touch() -> _create_file()
25. By Eric Snow on 2016-08-19: Clarify some comments.
26. By Eric Snow on 2016-08-19: Add missing test docstrings.
27. By Eric Snow on 2016-08-19: Explicitly pass the juju command in to the various functions.
28. By Eric Snow on 2016-08-19: Add CommandWrapper.
29. By Eric Snow on 2016-08-23: Add the Juju class.

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

People subscribed via source and target branches

to all changes: