Merge lp://qastaging/~evarlast/charms/precise/hive/encoding into lp://qastaging/charms/hive

Proposed by Jay R. Wren
Status: Work in progress
Proposed branch: lp://qastaging/~evarlast/charms/precise/hive/encoding
Merge into: lp://qastaging/charms/hive
Diff against target: 14 lines (+4/-0)
1 file modified
hooks/hive-common (+4/-0)
To merge this branch: bzr merge lp://qastaging/~evarlast/charms/precise/hive/encoding
Reviewer Review Type Date Requested Status
amir sanjar (community) Needs Information
Chris Glass (community) Approve
charmers Pending
Review via email: mp+226540@code.qastaging.launchpad.net

Description of the change

relation-set encoding=latin1 on relation joined to work with mysql charm which uses this to create database with this encoding.

Is a no-op if a different mysql charm is used.

To post a comment you must log in.
Revision history for this message
Chris Glass (tribaal) wrote :

Will that work with the current trunk mysql charm (that does *not* have this branch merged in https://code.launchpad.net/~evarlast/charms/precise/mysql/encoding)?

review: Needs Information
Revision history for this message
Jay R. Wren (evarlast) wrote :

It will work as a no-op. Relation interfaces are convention based. The mysql charm will never call relation-get, and so this hive charm will continue to function as it has been with the current mysql charm.

Revision history for this message
Chris Glass (tribaal) wrote :

You're correct, looks good! +1

review: Approve
Revision history for this message
amir sanjar (asanjar) wrote :

why not port the changes to hive2 with hive-server2 charm? Hive 0.8.2 is absolute

Revision history for this message
amir sanjar (asanjar) wrote :

please look at latest hive charms (hortonworks hive 0.13.0)
lp:~asanjar/charms/trusty/hdp-hive/trunk
Apache Hive 0.11.3
https://code.launchpad.net/~asanjar/charms/precise/hive2/trunk

review: Needs Information
Revision history for this message
Jay R. Wren (evarlast) wrote :

This change is only because of this bug: https://bugs.launchpad.net/charms/+source/mysql/+bug/965094

If this charm is obsolete, is there a way to mark it as such?

Unmerged revisions

8. By Jay R. Wren

relation-set encoding=latin1 on joined

requires updated mysql charm to work, doesn't break anything (noop)
with older mysql

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: