Merge lp://qastaging/~evfool/synaptic/fix791135 into lp://qastaging/synaptic
Proposed by
Robert Roth
| Status: | Merged |
|---|---|
| Merged at revision: | 1889 |
| Proposed branch: | lp://qastaging/~evfool/synaptic/fix791135 |
| Merge into: | lp://qastaging/synaptic |
| Diff against target: |
47 lines (+12/-11) 1 file modified
gtk/gsynaptic.cc (+12/-11) |
| To merge this branch: | bzr merge lp://qastaging/~evfool/synaptic/fix791135 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| synaptic-developers | Pending | ||
|
Review via email:
|
|||
Description of the change
Moved parsing the command line arguments and displaying the help before the check for administrative privileges, as these should be able to execute without having administrative privileges. Displaying an error in case of wrong command line arguments also does not require administrative privileges. Fixes bug #791135.
To post a comment you must log in.
Revision history for this message
| Luke Yelavich (themuso) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for your work. This is a change that would be useful in Debian as well. Would you mind filing a bug with Debian, and attaching the patch there? If this patch were to be accepted, we would get the patch a little later on in Oneiric, without having to carry another Ubuntu-specific change, which this is certainly not.
Thanks again.