Software Updater

Merge lp://qastaging/~evfool/update-manager/lp1081099 into lp://qastaging/update-manager

lp1081099
Merge into main

Proposed by Robert Roth on 2012-11-22

Status:

Merged

Merged at revision:

2559

Proposed branch:

lp://qastaging/~evfool/update-manager/lp1081099

Merge into:

lp://qastaging/update-manager

Diff against target:

11 lines (+1/-0)

1 file modified

data/gtkbuilder/UpdateManager.ui (+1/-0)

To merge this branch:

bzr merge lp://qastaging/~evfool/update-manager/lp1081099

Low

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Didier Roche-Tolomelli	2012-11-22	Approve on 2012-11-23
Matthew Paul Thomas	2012-11-22	Pending
Review via email: mp+135764@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2012-11-20.

Description of the change

Fixed buttons alignment by adding 6px border width.

Revision history for this message

Matthew Paul Thomas (mpt) wrote on 2012-11-20: Posted in a previous version of this proposal

Thanks Robert! Unfortunately, it's still one pixel off on both left and right. <http://imgur.com/IlyvK> I don't know whether that's the fault of the box containing the buttons, or the box containing the rest.

review: Needs Fixing

Revision history for this message

Robert Roth (evfool) wrote on 2012-11-20: Posted in a previous version of this proposal

Thanks mpt for the heads-up... that was the lazy me, just checking the result at first sight. I have fixed it now, the problem was with the button box, now there's 12 px border for all components (as far as I have found, it should be 12px, 13px would be kindof strange), and now the button is pixel-perfectly aligned with the treeview and the icon. I guess that should be fine, but let me know if you spot anything else to fix.

Revision history for this message

Didier Roche-Tolomelli (didrocks) wrote on 2012-11-23:

Looking good to me and seems to address mpt's comment.

Pushing to trunk for now :)

review: Approve