Merge lp://qastaging/~evgeni/libindicator/multiarch-same-devheaders into lp://qastaging/libindicator/12.10
Proposed by
Evgeni Golov
| Status: | Merged |
|---|---|
| Approved by: | Charles Kerr |
| Approved revision: | 468 |
| Merged at revision: | 468 |
| Proposed branch: | lp://qastaging/~evgeni/libindicator/multiarch-same-devheaders |
| Merge into: | lp://qastaging/libindicator/12.10 |
| Diff against target: |
27 lines (+3/-3) 2 files modified
libindicator/indicator-object-enum-types.c.template (+2/-2) libindicator/indicator-object-enum-types.h.template (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~evgeni/libindicator/multiarch-same-devheaders |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Charles Kerr (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
don't include build-time filenames in comments of the enum header files
If we do, the header files may be different on each build.
This is especially harmful when building multiple times for multiple
architectures and expecting the files to be identical.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I wouldn't've thought of that.
Nice catch. :)