Divmod

Merge lp://qastaging/~exarkun/divmod.org/nevow-setup.py-simpler-code into lp://qastaging/divmod.org

  1. nevow-setup.py-simpler-code
  2. Merge into trunk
Proposed by Jean-Paul Calderone
Status: Merged
Approved by: Tristan Seligmann
Approved revision: 2744
Merged at revision: 2744
Proposed branch: lp://qastaging/~exarkun/divmod.org/nevow-setup.py-simpler-code
Merge into: lp://qastaging/divmod.org
Prerequisite: lp://qastaging/~exarkun/divmod.org/nevow-setup.py-mandatory-setuptools
Diff against target: 69 lines (+18/-23)
1 file modified
Nevow/setup.py (+18/-23)
To merge this branch: bzr merge lp://qastaging/~exarkun/divmod.org/nevow-setup.py-simpler-code
Reviewer Review Type Date Requested Status
Tristan Seligmann Approve
Review via email: mp+222430@code.qastaging.launchpad.net

Commit message

Simplify the code invoking `setuptools.setup` in Nevow's setup.py now that it does not depend on any conditions.

To post a comment you must log in.
Revision history for this message
Jean-Paul Calderone (exarkun) wrote :

The intent is that no argument values have changed. Effectively all I've done is replaced `setup(**dict)` with `setup(keyword=arguments)`.

I verified that the resulting wheel and sdist produced are the same (modulo changes to the included setup.py that this branch makes).

Revision history for this message
Tristan Seligmann (mithrandi) wrote :

This also looks good, please merge.

Additionally, thanks for splitting these changes up; it made reviewing them substantially easier (although I fear at the cost of the actual changes being three times as much work).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches