Merge lp://qastaging/~fabiozaramella/foto/use-bottom-toolbar into lp://qastaging/foto/foto-1.0
Proposed by
Fabio Zaramella
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Erasmo Marín | ||||
Approved revision: | 111 | ||||
Merged at revision: | 105 | ||||
Proposed branch: | lp://qastaging/~fabiozaramella/foto/use-bottom-toolbar | ||||
Merge into: | lp://qastaging/foto/foto-1.0 | ||||
Diff against target: |
964 lines (+209/-367) 13 files modified
CMakeLists.txt (+1/-2) po/foto.pot (+1/-1) src/AppWindow.vala (+1/-0) src/dialogs/AddToAlbumDialog.vala (+12/-7) src/pages/AlbumPage.vala (+4/-37) src/pages/CollectionPage.vala (+81/-45) src/pages/LastImportedPage.vala (+2/-36) src/pages/LibraryPage.vala (+6/-39) src/pages/Page.vala (+9/-55) src/pages/TagPage.vala (+4/-37) src/widgets/ItemSearchBar.vala (+0/-48) src/widgets/ItemSortBar.vala (+0/-60) src/widgets/ItemSortSearchBar.vala (+88/-0) |
||||
To merge this branch: | bzr merge lp://qastaging/~fabiozaramella/foto/use-bottom-toolbar | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Fabio Zaramella | Needs Information | ||
Erasmo Marín | Needs Fixing | ||
Review via email:
|
This proposal supersedes a proposal from 2014-09-26.
To post a comment you must log in.
really nice work, some questions:
-Can be the border of the toolbar only applied in the top border?
-why not to put the selection button in the bottom toolbar? import to left, and search to right?
a suggestion:
-The "unselect" button looks useless to me, because when you are in single mode selection, clicking the selected item deselect it, and when you are in multiple selection, you just click the selection button and all items are unselected automatically. It can be removed.