Noise

Merge lp://qastaging/~fabiozaramella/noise/dont-use-headerbar into lp://qastaging/~elementary-apps/noise/trunk

  1. dont-use-headerbar
  2. Merge into trunk
Proposed by Fabio Zaramella
Status: Merged
Merged at revision: 1654
Proposed branch: lp://qastaging/~fabiozaramella/noise/dont-use-headerbar
Merge into: lp://qastaging/~elementary-apps/noise/trunk
Diff against target: 53 lines (+19/-5)
1 file modified
src/Dialogs/PreferencesWindow.vala (+19/-5)
To merge this branch: bzr merge lp://qastaging/~fabiozaramella/noise/dont-use-headerbar
Reviewer Review Type Date Requested Status
xapantu (community) Approve
Cody Garver Pending
Review via email: mp+223623@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2014-05-31.

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote : Posted in a previous version of this proposal

Gtk.Box is/is going to be deprecated, use Grid instead https://developer.gnome.org/gtk3/3.7/gtk-migrating-GtkGrid.html

review: Needs Fixing
Revision history for this message
Fabio Zaramella (fabiozaramella) wrote :

it's ok

lp://qastaging/~fabiozaramella/noise/dont-use-headerbar updated
1618. By Fabio

uses headerbar but hides the close button

Revision history for this message
Corentin Noël (tintou) wrote :

Please reuse Object (use_header_bar: 1);
and use get_header_bar () to get the header_bar object.

lp://qastaging/~fabiozaramella/noise/dont-use-headerbar updated
1619. By Fabio

need to hide the close button

1620. By Fabio

show_close_button (false)

Revision history for this message
Fabio Zaramella (fabiozaramella) wrote :

done

Revision history for this message
Cody Garver (codygarver) wrote :

Dragging the titlebar drags the whole app, none of the other preferences behave that way

lp://qastaging/~fabiozaramella/noise/dont-use-headerbar updated
1621. By Fabio

transient_for removed

Revision history for this message
Cody Garver (codygarver) wrote :

What's the purpose of the 'Allow moving the window' stuff?

Revision history for this message
Fabio Zaramella (fabiozaramella) wrote :

Oh it's remained from the tests I was doing. Personally I think that in this way is easier and faster for the user to drag the window instead of being forced to grab the title bar which has also a smaller area. However, if the team thinks it doesn't fit good i can remove it immediately.

Revision history for this message
xapantu (xapantu) wrote :

I removed that code and merged it, thanks for your work!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches