Merge ~facelessuser/beautifulsoup:bugfix/soupsieve into beautifulsoup:master
Proposed by
Isaac Muse
Status: | Merged |
---|---|
Merged at revision: | a01835fcf30959eb286850b6c5fd1dd7ef52bd4c |
Proposed branch: | ~facelessuser/beautifulsoup:bugfix/soupsieve |
Merge into: | beautifulsoup:master |
Diff against target: |
140 lines (+40/-25) 2 files modified
bs4/css.py (+29/-8) bs4/tests/test_css.py (+11/-17) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Leonard Richardson | Pending | ||
Review via email: mp+437154@code.qastaging.launchpad.net |
Commit message
Remove unnecessary test and don't pass namespace on precompiled select
Description of the change
Test that tries to run unknown soupsieve method no longer has
code associated with it, so the test is not needed.
If a precompiled pattern is passed into bs4, it should not pass
namespaces as the precompiled pattern already has that context
and can't be recompiled with new context.
To post a comment you must log in.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
So, I've reconsidered whether we need compile. I realize now that the compile object needs the documents namespace so as not to confuse users who expect it to be there. So compile should acquire this just like other methods unless the user specifically specifies it themselves.