lp://qastaging/~faenil/ubuntu-ui-toolkit/fix_scrollbar_tests_qt56

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://qastaging/ubuntu-ui-toolkit/staging at revision 2107

ubuntu-sdk-build-bot: Approve (continuous-integration) on 2016-09-19

Zsombor Egri: Approve on 2016-09-19

Cris Dywan: Pending requested 2016-09-17

Diff: 43 lines (+4/-4)

2 files modified

tests/unit/visual/tst_scrollbar.13.qml (+3/-3)
tests/unit/visual/tst_scrollbar_header.13.qml (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1624337: Scrollbar tests fail on Qt 5.6.

Critical

Fix Committed

Link a bug report

Related blueprints

2106. By Andrea Bernabei on 2016-09-17

Scrollbar: fix unit tests by passing all parameters to mapToItem. Fixes tests on Qt5.6

mapToItem takes (item, x, y) as parameters. The unit tests were previously
relying on JS automatically defining x,y as 0 when they were not passed
as parameters.

We were lucky that worked in the past, but Qt5.6 has a stricter
control over parameters and it throws TypeError when not all of them
are provided.

See QTBUG-41686 and its fix.

2105. By Andrea Bernabei on 2016-09-17

Scrollbar: update slider in default styling unit test

2104. By Tim Peeters on 2016-09-16

Do not skip Xenial and Yakkety series for running unit tests.

Individual unit tests that fail with Qt 5.6 have been disabled, and bugs are reported here: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bugs?field.tag=qt5.6.

Approved by ubuntu-sdk-build-bot, Zoltan Balogh.

2103. By Zsombor Egri on 2016-09-16

Do not show focus frame on disabled items. Fixes: https://bugs.launchpad.net/bugs/1611327.

Approved by ubuntu-sdk-build-bot, Tim Peeters.

2102. By Zoltan Balogh on 2016-09-15

sync with trunk

2101. By Zsombor Egri on 2016-09-15

Fix regression on ActionList API. Fixes: https://bugs.launchpad.net/bugs/1623841.

Approved by ubuntu-sdk-build-bot, Christian Dywan.

2100. By Cris Dywan on 2016-09-13

Correctly test and fix trigger override of ComboButton. Fixes: https://bugs.launchpad.net/bugs/1614045.

Approved by ubuntu-sdk-build-bot, Zsombor Egri.

2099. By Loïc Molinari on 2016-09-13

Made use of Qt builtin to check GCC version.

Approved by ubuntu-sdk-build-bot, Benjamin Zeller.

2098. By Loïc Molinari on 2016-09-13

Cleaned up ubuntu_qt_module.prf and the libs using it.

1/ Moved the common config options from the pro files to the prf file to avoid duplications and simplify the files.

2/ Removed the useless "TEMPLATE=lib" and "load(qt_build_config)" lines from the pro files since it's done for us by qt_module.prf.

3/ Use QT= instead of QT*= since it's well defined that by default its content is "core gui".

4/ Prefixed headers and sources by $$PWD/ and sorted the lines alphabetically.

5/ Merged the SOURCES declarations in UbuntuToolkit.pro.

6/ Removed the useless "DEFINES += QT_USE_QSTRINGBUILDER" line from UbuntuToolkit.pro since it's done for us by qt_module.prf.

7/ Removed the useless "QMAKE_CXXFLAGS -= -Werror=deprecated-declarations" and "DEFINES -= QT_DEPRECATED_WARNINGS" lines from UbuntuToolkit.pro since it's already done in ubuntu_qt_module.prf.

8/ Added a few comments.

Approved by ubuntu-sdk-build-bot, Zsombor Egri.

2097. By Loïc Molinari on 2016-09-12

Fixed, cleaned up and standardised header inclusions.

Apart from the clean up and the readability improvements, this fixes a bunch of broken private header inclusions (#include "foo_p.h" in private headers instead of "private/foo_p.h" or better <Project/private/foo_p.h>), now all the private headers of the UITK can be included by the users withour compilation issues. It also removes a bunch of direct includes from sources and a few INCLUDEPATHs hacks.

See the CODING file for more details.

Approved by ubuntu-sdk-build-bot, Zsombor Egri.