Merge lp://qastaging/~fagerstedt-axel/lava-android-test/linaro-android-kernel-test into lp://qastaging/lava-android-test

Proposed by Axel Fagerstedt
Status: Merged
Merged at revision: 237
Proposed branch: lp://qastaging/~fagerstedt-axel/lava-android-test/linaro-android-kernel-test
Merge into: lp://qastaging/lava-android-test
Diff against target: 95 lines (+32/-35)
3 files modified
doc/tests.rst (+3/-3)
lava_android_test/test_definitions/commands/ashmemtest.py (+0/-32)
lava_android_test/test_definitions/commands/linaro_android_kernel_test.py (+29/-0)
To merge this branch: bzr merge lp://qastaging/~fagerstedt-axel/lava-android-test/linaro-android-kernel-test
Reviewer Review Type Date Requested Status
Yongqin Liu Approve
Review via email: mp+148501@code.qastaging.launchpad.net

Description of the change

Adds a new test, linaro_android_kernel_test, this will run all the linaro android kernel unit tests.

Ashmemtest is removed as it will be run by the new test.

To post a comment you must log in.
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Seems reasonable to me. Could these tests be run with lava-test-shell?
That's becoming the prefered way to do things if you don't need to
fiddle with adb specifically.

Revision history for this message
Axel Fagerstedt (fagerstedt-axel) wrote :

It would absolutely make sense to run it as lava-test-shell

Last I head android-build does not yet support posting lava-test-shell jobs (being worked on) so I did this first, next step will be to publish a lava-test-shell definition.

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

Hi, Axel

just some questions:
1. is the linaro-android-kernel-tests.sh integrated into the build?
2. could you list some output to help to check if the pattern is right?
3. The following two lines should be unnecessary.
93 +import lava_android_test.testdef
95 +test_name = 'linaro_android_kernel_test'

Revision history for this message
Axel Fagerstedt (fagerstedt-axel) wrote :

1. yes (in the juice builds)

2. here is some example output (I have tested the parsing locally)

Running basic ashmemtest.
0 [ashmem_basic]: test passed

Running expanded ashmemtest.
running test0
-> got 1000 pages -> unpin 0..500 OK ret 0 -> pin 0..500 OK ret 0
[test0]: test passed

Running alarm dev test.
Error opening /dev/alarm
[alarmdevtest]: test failed

3. verifying and will upload a updated version shortly

237. By Axel Fagerstedt

linaro_android_kernel_test cleanup

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

liuyq> from the output, seem the result gotten by the pattern is failed or passed.
<liuyq> I am not very sure if the result of failed or passed can be accepted
<liuyq> could you help to run "lava-android-test run command-linaro_android_kernel_test -o result.json", and see if we can get the result in the result.json file?
<liuyq> if the command works well, then the source should be ok

And maybe we can rename the file name to kernel.py from linaro_android_kernel_test.py for a short.

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

<axelfagerstedt> I would prefer not to rename the suite to kernel.py as i believe there are other linaro test suites testing kernel functionality. This one is specifically testing android drivers.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches