Merge lp://qastaging/~fahlgren/command-not-found/speedup into lp://qastaging/~command-not-found-developers/command-not-found/trunk

Proposed by Daniel Fahlgren
Status: Superseded
Proposed branch: lp://qastaging/~fahlgren/command-not-found/speedup
Merge into: lp://qastaging/~command-not-found-developers/command-not-found/trunk
Diff against target: 15 lines (+4/-1)
1 file modified
CommandNotFound/CommandNotFound.py (+4/-1)
To merge this branch: bzr merge lp://qastaging/~fahlgren/command-not-found/speedup
Reviewer Review Type Date Requested Status
Zygmunt Krynicki Needs Fixing
Review via email: mp+70928@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2011-08-09.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Could you please add a note that explains what this argument does and call it by name (...withMatcher=False) and then it can go in.

review: Needs Fixing
138. By Daniel Fahlgren

Add note what the argument it for. Also use the arguments name in the
call.

139. By Daniel Fahlgren

add better note

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for your branch! I'm curious what kind of speedup we get with it, are there any numbers for this :) ?

Unmerged revisions

139. By Daniel Fahlgren

add better note

138. By Daniel Fahlgren

Add note what the argument it for. Also use the arguments name in the
call.

137. By Daniel Fahlgren

When CommandNotFound.py calls SourcesList is there a lot of information
parsed that is never used. This reduces the execution time with ~35-45%
depending on hardware. Tested on an i5-2410M and an Atom 330 with natty
64 bit installed. The command tested is "cab".

136. By Michael Vogt

releasing version 0.2.41ubuntu5

135. By Michael Vogt

releasing version 0.2.41ubuntu4

134. By Michael Vogt

releasing version 0.2.41ubuntu3

133. By Michael Vogt

* automatically update the scan.data in the pre-build.sh hook
  (thanks to Steve Langasek for this suggestion)
* updated to oneiric

132. By Michael Vogt

Migrate to dh_python2. LP: #788514.

131. By Michael Vogt

releasing version 0.2.41ubuntu2

130. By Michael Vogt

update-from-web.sh: updated for the new scan.1 scan.2 data

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches