Merge lp://qastaging/~fazerlicourice/ubuntu-weather-app/add-test-switch-data-providers into lp://qastaging/ubuntu-weather-app

I won't probably be able to review this until tomorrow. However, you are correct in that you need a TWC key. The weather devs can explain it better than I.

Looks good so far, I've added quite a few comments let me know if any don't make sense.

I'm unable to revert a file. I did bzr revert CMakeLists.txt.user but it didn't work.

Are we happy with this now?

Not yet, some issues still stand.

@fazer, try passing -r with the revision to go back to with the bzr revert command, or if that doesn't work I can have a look into other ways to revert it.

FAILED: Continuous integration, rev:217
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~fazerlicourice/ubuntu-weather-app/add-test-switch-data-providers/+merge/283749/+edit-commit-message

https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/990/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/537/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/990/rebuild

How do I trigger a re-build of Jenkins? Or is that something only you can do?

FAILED: Continuous integration, rev:220
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1022/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/574/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1022/rebuild

How is this coming along? Do we feel this test is possible using qmltestrunner instead of autopilot?

FAILED: Continuous integration, rev:220
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1045/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/597/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1045/rebuild

FAILED: Continuous integration, rev:221
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1046/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/598/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/1046/rebuild

Sorry for the very long review time.

This failed with

Traceback (most recent call last):
  File "/tmp/adt-run.7DdPR6/tree/tests/autopilot/ubuntu_weather_app/tests/test_settings_page.py", line 178, in test_switch_service
    self._check_provider("weatherchannel")
  File "/tmp/adt-run.7DdPR6/tree/tests/autopilot/ubuntu_weather_app/tests/test_settings_page.py", line 77, in _check_provider
    self.data_provider_page.click_back()
AttributeError: 'TestSettingsPage' object has no attribute 'data_provider_page'

Seems you either need todo the click_back() before the self._check_provider(service) or pass the data_provider_page as a parameter, although I think the first solution in this case will be the most extensible in the future.

Also you might want to merge with trunk as your other MP landed, so there could be conflicts.

Alright, will get on it as soon as possible, busy time at school.

Is there an irc channel for the weather app? If I need to run some stuff by someone else?

Also, I keep gettign an error that says I can't find any of List items in the settings page. I'm using this command:

self.wait_select_single("StandardListItem", title=listitem_title)

listitem_title is a method parameter.( http://bazaar.launchpad.net/~ubuntu-weather-dev/ubuntu-weather-app/reboot/view/head:/tests/autopilot/ubuntu_weather_app/__init__.py#L286 )

It looks like they should be a StandardListItem, check in Autopilot Vis to ensure they aren't another type and check that the test is actually on the correct page when trying to find the listitems.

There is an IRC channel for app development in general for Ubuntu, which is #ubuntu-app-devel, I and many others hang around in there :-) Further channels such as #ubuntu-autopilot #ubuntu-quality and #ubuntu-touch can be useful, for a full list refer to [0].

Let me know if you can't figure out the listitem issue.

0 - https://wiki.ubuntu.com/IRC/ChannelList