address-book-app

Merge lp://qastaging/~fboucault/address-book-app/multicolumns into lp://qastaging/address-book-app

multicolumns
Merge into trunk

Proposed by Florian Boucault on 2015-09-03

Status:	Merged
Approved by:	Renato Araujo Oliveira Filho on 2015-10-23
Approved revision:	474
Merged at revision:	490
Proposed branch:	lp://qastaging/~fboucault/address-book-app/multicolumns
Merge into:	lp://qastaging/address-book-app
Prerequisite:	lp://qastaging/~fboucault/address-book-app/toolkit13
Diff against target:	349 lines (+63/-59) 11 files modified src/imports/ABContactListPage.qml (+25/-18) src/imports/ABContactViewPage.qml (+14/-9) src/imports/MainWindow.qml (+8/-16) src/imports/Settings/SettingsPage.qml (+1/-1) src/imports/Ubuntu/AddressBook/ContactEditor/ContactEditorPage.qml (+3/-4) src/imports/Ubuntu/AddressBook/ContactShare/ContactSharePage.qml (+2/-2) src/imports/Ubuntu/Contacts/ContactListView.qml (+4/-4) src/imports/Ubuntu/Contacts/ContactSimpleListView.qml (+2/-1) src/imports/Ubuntu/Contacts/ListItemWithActions.qml (+1/-1) src/imports/Ubuntu/Contacts/PageWithBottomEdge.qml (+1/-1) src/imports/Ubuntu/Contacts/SIMCardImportPage.qml (+2/-2)
To merge this branch:	bzr merge lp://qastaging/~fboucault/address-book-app/multicolumns
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Renato Araujo Oliveira Filho (community)		2015-09-03	Approve on 2015-10-23
PS Jenkins bot	continuous-integration		Needs Fixing on 2015-10-16
Review via email: mp+270113@code.qastaging.launchpad.net

Commit message

Use AdaptivePageLayout instead of PageStack to support multi column layouts.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-03:

FAILED: Continuous integration, rev:471
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/905/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/208/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4008/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4005/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/905/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~fboucault/address-book-app/multicolumns updated on 2015-09-04

472. By Florian Boucault on 2015-09-04: Merged from toolkit13

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-04:

FAILED: Continuous integration, rev:472
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/907/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/210
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4020
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3281
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4017
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4017/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23065

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/907/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) wrote on 2015-09-04:

- Is correct that the edit page has a small header than other pages?
- Is correct that when opening the edit page from the bottom edge it fills only the right side page? Keeping the left side page empty?

lp://qastaging/~fboucault/address-book-app/multicolumns updated on 2015-09-04