address-book-app

Merge lp://qastaging/~fboucault/address-book-app/startup_time into lp://qastaging/address-book-app

  1. startup_time
  2. Merge into trunk
Proposed by Florian Boucault
Status: Merged
Approved by: Florian Boucault
Approved revision: 646
Merged at revision: 645
Proposed branch: lp://qastaging/~fboucault/address-book-app/startup_time
Merge into: lp://qastaging/address-book-app
Diff against target: 1233 lines (+458/-313)
32 files modified
debian/control (+1/-1)
debian/control.in (+1/-1)
src/imports/ABContactEditorPageWithEmptyContact.qml (+27/-0)
src/imports/ABContactListPage.qml (+15/-69)
src/imports/ABContactViewPage.qml (+11/-19)
src/imports/ABEmptyState.qml (+1/-0)
src/imports/ABMultiColumnEmptyState.qml (+11/-9)
src/imports/ABNewContactBottomEdge.qml (+22/-17)
src/imports/BusyImportingDialog.qml (+48/-0)
src/imports/CMakeLists.txt (+3/-0)
src/imports/MainWindow.qml (+0/-17)
src/imports/RemoveContactsDialog.qml (+36/-0)
src/imports/Ubuntu/AddressBook/Base/BusyExportingDialog.qml (+31/-0)
src/imports/Ubuntu/AddressBook/Base/CMakeLists.txt (+1/-0)
src/imports/Ubuntu/AddressBook/Base/ContactExporter.qml (+1/-16)
src/imports/Ubuntu/AddressBook/ContactEditor/AlertMessageDialog.qml (+53/-0)
src/imports/Ubuntu/AddressBook/ContactEditor/AvatarImport.qml (+5/-82)
src/imports/Ubuntu/AddressBook/ContactEditor/AvatarImportDialog.qml (+98/-0)
src/imports/Ubuntu/AddressBook/ContactEditor/CMakeLists.txt (+3/-0)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactEditorPage.qml (+7/-77)
src/imports/Ubuntu/AddressBook/ContactEditor/RemoveContactsDialog.qml (+60/-0)
src/imports/Ubuntu/AddressBook/ContactEditor/ValueSelector.qml (+2/-0)
src/imports/Ubuntu/AddressBook/ContactView/ActionButton.qml (+1/-0)
src/imports/Ubuntu/AddressBook/ContactView/ContactDetailAvatarView.qml (+1/-0)
src/imports/Ubuntu/AddressBook/ContactView/ContactDetailWithTypeView.qml (+1/-0)
src/imports/Ubuntu/AddressBook/ContactView/ContactViewPage.qml (+1/-5)
src/imports/Ubuntu/Contacts/ActionButton.qml (+1/-0)
src/imports/Ubuntu/Contacts/ContactAvatar.qml (+1/-0)
src/imports/Ubuntu/Contacts/ContactDetailPickerPhoneNumberDelegate.qml (+1/-0)
src/imports/Ubuntu/Contacts/ContactListButtonDelegate.qml (+2/-0)
src/imports/Ubuntu/Contacts/ListItemWithActions.qml (+2/-0)
tests/qml/tst_ContactList.qml (+10/-0)
To merge this branch: bzr merge lp://qastaging/~fboucault/address-book-app/startup_time
Reviewer Review Type Date Requested Status
Renato Araujo Oliveira Filho (community) Approve
system-apps-ci-bot continuous-integration Needs Fixing
Review via email: mp+306886@code.qastaging.launchpad.net

Commit message

Reduced startup time (by 600ms on krillin):
- Bottom edge: delay compiling contact editor page.
- Load Icons asynchronously.
- Made all Components compile asynchronously when possible.

Made startup time overhead when lots of contacts in address book as small as possible

Description of the change

Reduced startup time (by 600ms on krillin):
- Bottom edge: delay compiling contact editor page.
- Load Icons asynchronously.
- Made all Components compile asynchronously when possible.

Made startup time overhead when lots of contacts in address book as small as possible

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:643
https://jenkins.canonical.com/system-apps/job/lp-address-book-app-ci/28/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1642/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1642
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1488
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1488/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1488
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1488/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1488/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1488
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1488/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1488
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1488/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1488
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1488/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1488/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1488
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1488/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1488
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1488/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-address-book-app-ci/28/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:644
https://jenkins.canonical.com/system-apps/job/lp-address-book-app-ci/29/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1765/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1765
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1609
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1609/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1609
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1609/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1609
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1609/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1609/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1609/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1609
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1609/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1609
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1609/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1609
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1609/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1609
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1609/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-address-book-app-ci/29/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches