camera-app

Merge lp://qastaging/~fboucault/camera-app/add_flake8_to_unittests into lp://qastaging/camera-app/staging

Proposed by Florian Boucault on 2016-02-26

Status:	Merged
Approved by:	Florian Boucault on 2016-02-26
Approved revision:	660
Merged at revision:	659
Proposed branch:	lp://qastaging/~fboucault/camera-app/add_flake8_to_unittests
Merge into:	lp://qastaging/camera-app/staging
Diff against target:	26 lines (+1/-4) 2 files modified debian/rules (+0/-4) tests/unittests/CMakeLists.txt (+1/-0)
To merge this branch:	bzr merge lp://qastaging/~fboucault/camera-app/add_flake8_to_unittests
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Needs Fixing on 2016-02-26
Olivier Tilloy		2016-02-26	Approve on 2016-02-26
Review via email: mp+287321@code.qastaging.launchpad.net

Add flake8 tests to unit tests

Revision history for this message

Olivier Tilloy (osomon) wrote on 2016-02-26:

You probably want to remove the call to flake8 in debian/rules.
Otherwise this looks good.

review: Approve

Revision history for this message

Olivier Tilloy (osomon) wrote on 2016-02-26:

(actually you can entirely remove the dh_auto_test override)

Revision history for this message

Florian Boucault (fboucault) wrote on 2016-02-26:

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-02-26:

review: Needs Fixing (continuous-integration)

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

People subscribed via source and target branches

to all changes: