Merge lp://qastaging/~fboucault/camera-app/always_check_resolution_is_option into lp://qastaging/camera-app/staging
Proposed by
Florian Boucault
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Ugo Riboni | ||||
| Approved revision: | 643 | ||||
| Merged at revision: | 643 | ||||
| Proposed branch: | lp://qastaging/~fboucault/camera-app/always_check_resolution_is_option | ||||
| Merge into: | lp://qastaging/camera-app/staging | ||||
| Diff against target: |
52 lines (+26/-7) 1 file modified
ViewFinderOverlay.qml (+26/-7) |
||||
| To merge this branch: | bzr merge lp://qastaging/~fboucault/camera-app/always_check_resolution_is_option | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Needs Fixing | |
| Ugo Riboni (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Before setting a photo capture resolution, always checks it is included in the possible resolution options.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM and does not break anything on krillin (can't test on mx4)