camera-app

Merge lp://qastaging/~fboucault/camera-app/async_lib_loading into lp://qastaging/camera-app

  1. async_lib_loading
  2. Merge into trunk
Proposed by Florian Boucault
Status: Merged
Approved by: Bill Filler
Approved revision: 485
Merged at revision: 473
Proposed branch: lp://qastaging/~fboucault/camera-app/async_lib_loading
Merge into: lp://qastaging/camera-app
Diff against target: 658 lines (+233/-109)
10 files modified
CameraApp/foldersmodel.cpp (+113/-61)
CameraApp/foldersmodel.h (+19/-3)
GalleryView.qml (+39/-1)
GalleryViewLoader.qml (+5/-0)
PhotogridView.qml (+1/-6)
SlideshowView.qml (+6/-0)
ViewFinderView.qml (+11/-10)
camera-app.qml (+8/-2)
po/camera-app.pot (+26/-22)
tests/autopilot/camera_app/tests/test_gallery_view.py (+5/-4)
To merge this branch: bzr merge lp://qastaging/~fboucault/camera-app/async_lib_loading
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+247485@code.qastaging.launchpad.net

Commit message

Asynchronously scan the filesystem for media. Fixes freeze at startup with a huge amount of media.
Significantly faster deletion when deleting a huge amount of media.
Taking a photo is now always fast even with a huge amount of media.

To post a comment you must log in.
lp://qastaging/~fboucault/camera-app/async_lib_loading updated
474. By Florian Boucault

Faster scanning.

475. By Florian Boucault

Sorting is still important.

476. By Florian Boucault

Reverted pointless change

477. By Florian Boucault

Do not scan until FoldersModel is fully instantiated.

478. By Florian Boucault

Clear model immediately when updating.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:474
http://jenkins.qa.ubuntu.com/job/camera-app-ci/358/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/54
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/54
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/54/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/54
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/88/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/439
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/728/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/183
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17406
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/360
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/531
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/531/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/358/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~fboucault/camera-app/async_lib_loading updated
479. By Florian Boucault

Vastly more efficient selectAll with large collections.

480. By Florian Boucault

Fixed deletion bug.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:480
http://jenkins.qa.ubuntu.com/job/camera-app-ci/359/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/55
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/55
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/55/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/55
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/90/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/441
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/730/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/185
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17410
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/362
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/533
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/533/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/359/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~fboucault/camera-app/async_lib_loading updated
481. By Florian Boucault

Do not monitor for added file anylonger, instead manually prepend new media files shot. Depends on fix in qtubuntu-camera https://code.launchpad.net/~fboucault/qtubuntu-camera/fix_video_location/+merge/247507

482. By Florian Boucault

Significantly faster deletion of selected files.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:482
http://jenkins.qa.ubuntu.com/job/camera-app-ci/361/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/57
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/57
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/57/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/57
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/92/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/444
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/732/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/188
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17412
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/364
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/536
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/536/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/361/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~fboucault/camera-app/async_lib_loading updated
483. By Florian Boucault

Added feedback while media scanning is in progress.

484. By Florian Boucault

Updated pot file.

485. By Florian Boucault

Fixed autopilot tests.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:484
http://jenkins.qa.ubuntu.com/job/camera-app-ci/362/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/58
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/58
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/58/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/58/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/94/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/449
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/734/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/190
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17418
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/368
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/541
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/541/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/362/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:485
http://jenkins.qa.ubuntu.com/job/camera-app-ci/363/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/59
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/59
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/59/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/59
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/96/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/451
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/736/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/192
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17420
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/369
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/543
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/543/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/363/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches