camera-app

Merge lp://qastaging/~fboucault/camera-app/bottom_edge_mouse into lp://qastaging/camera-app/staging

  1. bottom_edge_mouse
  2. Merge into staging
Proposed by Florian Boucault
Status: Merged
Approved by: Ugo Riboni
Approved revision: 644
Merged at revision: 644
Proposed branch: lp://qastaging/~fboucault/camera-app/bottom_edge_mouse
Merge into: lp://qastaging/camera-app/staging
Diff against target: 44 lines (+18/-10)
1 file modified
ViewFinderOverlay.qml (+18/-10)
To merge this branch: bzr merge lp://qastaging/~fboucault/camera-app/bottom_edge_mouse
Reviewer Review Type Date Requested Status
Ugo Riboni (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+285334@code.qastaging.launchpad.net

Commit message

Fix bottom edge mouse handling:
- make sure that clicks are properly forwarded to click handler
- ensure that clicks on the bottom edge open it
- ensure that any click outside of option buttons dismiss the bottom edge

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:644
http://jenkins.qa.ubuntu.com/job/camera-app-staging-ci/30/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-amd64-ci/30
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-amd64-ci/30/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-armhf-ci/30
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-armhf-ci/30/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-i386-ci/30
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-i386-ci/30/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/401
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-touch/1071
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/971
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27385

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-staging-ci/30/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ugo Riboni (uriboni) wrote :

Works as it should and code looks ok

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches