camera-app

Merge lp://qastaging/~fboucault/camera-app/disable_controls_while_shooting into lp://qastaging/camera-app/staging

  1. disable_controls_while_shooting
  2. Merge into staging
Proposed by Florian Boucault
Status: Merged
Approved by: Ugo Riboni
Approved revision: 630
Merged at revision: 629
Proposed branch: lp://qastaging/~fboucault/camera-app/disable_controls_while_shooting
Merge into: lp://qastaging/camera-app/staging
Diff against target: 143 lines (+10/-13)
4 files modified
ViewFinderOverlay.qml (+6/-2)
ViewFinderOverlayLoader.qml (+0/-6)
ViewFinderView.qml (+3/-4)
camera-app.qml (+1/-1)
To merge this branch: bzr merge lp://qastaging/~fboucault/camera-app/disable_controls_while_shooting
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ugo Riboni (community) Approve
Review via email: mp+281827@code.qastaging.launchpad.net

Commit message

Disable all controls while a photo is being saved.

To post a comment you must log in.
lp://qastaging/~fboucault/camera-app/disable_controls_while_shooting updated
630. By Florian Boucault

Disable focus ring also

Revision history for this message
Ugo Riboni (uriboni) wrote :

Works as expected and simplifies previous code as a bonus, so all good

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:629
http://jenkins.qa.ubuntu.com/job/camera-app-staging-ci/9/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-amd64-ci/9
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-amd64-ci/9/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-armhf-ci/9
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-armhf-ci/9/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-i386-ci/9
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-staging-vivid-i386-ci/9/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/360
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-touch/1031
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/890
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26467

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-staging-ci/9/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches