Merge lp://qastaging/~fboucault/camera-app/no_cpu_usage_in_photo_roll into lp://qastaging/camera-app/staging
Proposed by
Florian Boucault
| Status: | Merged |
|---|---|
| Approved by: | Ugo Riboni |
| Approved revision: | 620 |
| Merged at revision: | 621 |
| Proposed branch: | lp://qastaging/~fboucault/camera-app/no_cpu_usage_in_photo_roll |
| Merge into: | lp://qastaging/camera-app/staging |
| Diff against target: |
127 lines (+34/-24) 4 files modified
SlideshowView.qml (+1/-1) ViewFinderOverlay.qml (+2/-7) ViewFinderOverlayLoader.qml (+4/-0) ViewFinderView.qml (+27/-16) |
| To merge this branch: | bzr merge lp://qastaging/~fboucault/camera-app/no_cpu_usage_in_photo_roll |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ugo Riboni (community) | Needs Information | ||
|
Review via email:
|
|||
Commit message
Fixed 2 CPU wasters:
- when in photo roll's grid mode, do not have the slideshow mode's ActivityIndicator running.
- when in photo roll, disable viewfinder.
To post a comment you must log in.
Revision history for this message
| Florian Boucault (fboucault) wrote | # |
Revision history for this message
| Florian Boucault (fboucault) | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
A little more details: camera.stop() was never meant to unload the camera stack. It only sets the camera's state to LoadedState, essentially stopping the viewfinder. That alone is not enough for other apps to use the camera hardware (with the Android's camera stack we use in Ubuntu Touch).
Unfortunately qtubuntu-camera was fully unloading the camera stack when the camera's state was set to LoadedState, the MR at [1] fixes that and therefore breaks the app.
[1] https:/