gallery-app

Merge lp://qastaging/~fboucault/gallery-app/sdcard into lp://qastaging/gallery-app

  1. sdcard
  2. Merge into trunk
Proposed by Florian Boucault
Status: Merged
Approved by: Bill Filler
Approved revision: 1118
Merged at revision: 1120
Proposed branch: lp://qastaging/~fboucault/gallery-app/sdcard
Merge into: lp://qastaging/gallery-app
Diff against target: 15 lines (+5/-0)
1 file modified
src/util/resource.cpp (+5/-0)
To merge this branch: bzr merge lp://qastaging/~fboucault/gallery-app/sdcard
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Arthur Mello Pending
Review via email: mp+243284@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2014-08-20.

Commit message

Append directory under /media/phablet to m_mediaDirectories, so photos captured onto SD card can be listed.

Description of the change

Append directory under /media/phablet to m_mediaDirectories, so photos captured onto SD card can be listed.

To post a comment you must log in.
Revision history for this message
Penk Chen (penk) wrote : Posted in a previous version of this proposal

Loop through /media sub directories and append it to mediaDirectories list if exists.

This is a related merge proposal of camera-app to add SD card support:
https://code.launchpad.net/~penk/camera-app/sdcard/+merge/231568

Revision history for this message
Arthur Mello (artmello) wrote : Posted in a previous version of this proposal

If this is still wanted, we could add the path to the sdcard to the list of monitored directories and gallery will automatically scan all the sub folders of it and add the media files found.

review: Needs Fixing
Revision history for this message
Penk Chen (penk) wrote : Posted in a previous version of this proposal

Hi @artmello this is very much needed.

Is it MediaMonitor or a separate configure file?

Revision history for this message
Arthur Mello (artmello) wrote : Posted in a previous version of this proposal

@penk, an append at m_mediaDirectories of ""/media/" + userName" should be enough to make gallery-app search for all media files on this dir and on all the subdirs. We do not have a config file for it today but we should think about it

Revision history for this message
Penk Chen (penk) wrote : Posted in a previous version of this proposal

Hi @artmello thank you for the hint, I have modified it accordingly in rev 1048.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1118
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1081/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/9
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/9/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/9
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/37
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/258/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/681
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/57
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16355
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/263/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1081/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches