Merge lp://qastaging/~fboucault/ubuntu-clock-app/fix_startup_time into lp://qastaging/ubuntu-clock-app

Proposed by Florian Boucault
Status: Merged
Approved by: Bartosz Kosiorek
Approved revision: 484
Merged at revision: 482
Proposed branch: lp://qastaging/~fboucault/ubuntu-clock-app/fix_startup_time
Merge into: lp://qastaging/ubuntu-clock-app
Diff against target: 243 lines (+43/-11)
9 files modified
app/MainPage.qml (+13/-10)
app/alarm/AlarmSettingsPage.qml (+3/-0)
app/alarm/AlarmSound.qml (+4/-0)
app/clock/ClockPage.qml (+12/-1)
app/components/ActionIcon.qml (+1/-0)
app/components/AnalogMode.qml (+7/-0)
app/components/EmptyState.qml (+1/-0)
app/components/ExpandableListItem.qml (+1/-0)
app/worldclock/AddWorldCityButton.qml (+1/-0)
To merge this branch: bzr merge lp://qastaging/~fboucault/ubuntu-clock-app/fix_startup_time
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Bartosz Kosiorek Approve
Review via email: mp+301045@code.qastaging.launchpad.net

Commit message

Improved startup time (1600ms saved on BQ E4.5):
- Load Images and Icons asynchronously
- Load bottom edge asynchronously
- Workaround PositionSource bug that was delaying startup by 1000ms

Description of the change

Improved startup time (1600ms saved on BQ E4.5):
- Load Images and Icons asynchronously
- Load bottom edge asynchronously
- Workaround PositionSource bug that was delaying startup by 1000ms

To post a comment you must log in.
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

Great improvement. Thanks.
I wish to decrease startup time for Contacts, Messages and Phone, which is took about 4 seconds.

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches