Merge lp://qastaging/~fboucault/ubuntu-facebook-app/remove_use_of_theming into lp://qastaging/ubuntu-facebook-app
Proposed by
Florian Boucault
| Status: | Merged |
|---|---|
| Approved by: | Michael Hall |
| Approved revision: | 7 |
| Merged at revision: | 7 |
| Proposed branch: | lp://qastaging/~fboucault/ubuntu-facebook-app/remove_use_of_theming |
| Merge into: | lp://qastaging/ubuntu-facebook-app |
| Diff against target: |
337 lines (+0/-323) 2 files modified
app-theme.qmltheme (+0/-322) ubuntu-facebook-app.qml (+0/-1) |
| To merge this branch: | bzr merge lp://qastaging/~fboucault/ubuntu-facebook-app/remove_use_of_theming |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
| Hugo Miguel Barbarrica Rodrigues Lima | Approve | ||
| Michael Hall | Pending | ||
|
Review via email:
|
|||
Commit message
Remove use of theming because the theming infrastructure in the toolkit is going to change drastically.
The theme was copied over almost entirely from the toolkit which should not be done. There was however one significant difference: the header background and height were customized. That capability might be introduced differently in the future. For now no custom header unfortunately.
To post a comment you must log in.
Revision history for this message
| Hugo Miguel Barbarrica Rodrigues Lima (hmiguellima) wrote | # |
review:
Approve
Revision history for this message
| Florian Boucault (fboucault) wrote | # |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Although the theming aspect of the Facebook app, and the specific header customization that was done, is problably needed for the app to be approved by Facebook, I completly agree, that the way it was done, by including the whole theme files, was wrong. Unfortunaltly I coould make it work in any other way, and the feedback I got from the mailing list didn't solve that.
If the theming infrastructure is going to change, I agree that the best thing for now is to remove this code, and wait until the api is more mature.