unity-2d

Merge lp://qastaging/~fboucault/unity-2d/dash_horizontal_renderer into lp://qastaging/unity-2d/3.0

dash_horizontal_renderer
Merge into natty

Proposed by Florian Boucault on 2011-06-22

Status:

Merged

Approved by:

Florian Boucault on 2011-06-23

Approved revision:

no longer in the source branch.

Merged at revision:

613

Proposed branch:

lp://qastaging/~fboucault/unity-2d/dash_horizontal_renderer

Merge into:

lp://qastaging/unity-2d/3.0

Diff against target:

137 lines (+133/-0)

1 file modified

places/UnityHorizontalTileRenderer.qml (+133/-0)

To merge this branch:

bzr merge lp://qastaging/~fboucault/unity-2d/dash_horizontal_renderer

Related bugs:

Bug #790319: Some community lenses do not display anything - UnityHorizontalRenderer not implemented	High	Fix Released
Bug #837712: [dash] Lacks horizontal renderer used by lenses such as Gwibber	Medium	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Joe Simpson (community)		2011-06-22	Approve on 2011-06-23
Review via email: mp+65488@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2011-06-15.

Commit message

[dash] Added a UnityHorizontalTileRenderer that is required by many community lenses (Gwibber lens, books lens, music lens, etc.)

Description of the change

I fixed a bug which is here:
https://bugs.launchpad.net/unity-2d/+bug/790319

Basically I made the renderer thing.

Revision history for this message

Florian Boucault (fboucault) wrote on 2011-06-22:

Thanks for the work Joe. I made a few modifications to the renderer you submitted. Can you please test them and see if everything is in order?
Thanks!

lp://qastaging/~fboucault/unity-2d/dash_horizontal_renderer updated on 2011-06-22

584. By Florian Boucault on 2011-06-22: Merged lp:unity-2d

Revision history for this message

Joe Simpson (headbangerkenny) wrote on 2011-06-23:

> Thanks for the work Joe. I made a few modifications to the renderer you
> submitted. Can you please test them and see if everything is in order?
> Thanks!

I did the merge command it tells me to do at the top of the page (I'm new to Bazzar and Launchpad!) and if that's the right thing to do, everything is in order!

Joe :)

Revision history for this message

Florian Boucault (fboucault) wrote on 2011-06-23:

Thanks a lot!

Revision history for this message

Joe Simpson (headbangerkenny) on 2011-06-23:

review: Approve