unity-2d

Merge lp://qastaging/~fboucault/unity-2d/launcher_interrupted_drag into lp://qastaging/unity-2d/3.0

  1. launcher_interrupted_drag
  2. Merge into natty
Proposed by Florian Boucault
Status: Merged
Approved by: Florian Boucault
Approved revision: 582
Merged at revision: 581
Proposed branch: lp://qastaging/~fboucault/unity-2d/launcher_interrupted_drag
Merge into: lp://qastaging/unity-2d/3.0
Diff against target: 18 lines (+8/-0)
1 file modified
launcher/ListViewDragAndDrop.qml (+8/-0)
To merge this branch: bzr merge lp://qastaging/~fboucault/unity-2d/launcher_interrupted_drag
Reviewer Review Type Date Requested Status
Olivier Tilloy (community) Needs Fixing
Pi Delport (community) Approve
Review via email: mp+62987@code.qastaging.launchpad.net

Description of the change

[launcher] Fix a case where the launcher became disabled after an incomplete drag forcing the user to log out and log in again.

It was due to the mouse button released signal not being emitted because a parent flickable was stealing the mouse grab.

To post a comment you must log in.
Revision history for this message
Pi Delport (pi-delport) wrote :

Works for me. The comment should maybe mention the bug number?

review: Approve
Revision history for this message
Florian Boucault (fboucault) wrote :

Thanks a lot Piet! I added a reference to the bug number.

lp://qastaging/~fboucault/unity-2d/launcher_interrupted_drag updated
581. By Florian Boucault

Added reference to the bug.

Revision history for this message
Olivier Tilloy (osomon) wrote :

That seems to fix the issue and my tests didn’t reveal regressions. Nice catch, this bug was a real bummer!

Tiny nitpick before I can approve: there is a typo in the comment: s/trigerred/triggered/

review: Needs Fixing
lp://qastaging/~fboucault/unity-2d/launcher_interrupted_drag updated
582. By Florian Boucault

Fixed typo.

Revision history for this message
Olivier Tilloy (osomon) wrote :

Picking nits further (but too late apparently): s/triggerred/triggered/ :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches