Merge lp://qastaging/~fboucault/unity-2d/multiline into lp://qastaging/unity-2d/3.0

Proposed by Florian Boucault
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 521
Merged at revision: 523
Proposed branch: lp://qastaging/~fboucault/unity-2d/multiline
Merge into: lp://qastaging/unity-2d/3.0
Diff against target: 110 lines (+47/-5)
4 files modified
places/HomeButton.qml (+2/-2)
places/RendererGrid.qml (+4/-0)
places/TextMultiLine.qml (+38/-0)
places/UnityDefaultRenderer.qml (+3/-3)
To merge this branch: bzr merge lp://qastaging/~fboucault/unity-2d/multiline
Reviewer Review Type Date Requested Status
Olivier Tilloy (community) Approve
Review via email: mp+56914@code.qastaging.launchpad.net

Description of the change

[dash] Labels are now multiline to allow for more text to be displayed and the user
to have a better chance to understand what the items are. Hovering over cropped labels
will expand them fully.

To post a comment you must log in.
Revision history for this message
Florian Boucault (fboucault) wrote :

There is a few things to take into account:
- this is a workaround for a missing feature in the Text QML element
- the Qt developers implemented the feature properly in a more recent Qt version: http://bugreports.qt.nokia.com/browse/QTBUG-12305 but the patch to Qt is quite intrusive and not trivial to backport to 4.7.2
- this workaround has a big, acceptable drawback: ellipsis never happens (the ... are never displayed)

Also it is a known issue that when hovering a result that has its label cut will expand the text over the rectangle that indicates the selection. It is not very pretty and we will devise a solution for that later.

Revision history for this message
Olivier Tilloy (osomon) wrote :

When I open the home page of the dash, I get 8 times the following warning:

unity-2d-places: [WARNING] file:///…/places/TextMultiLine.qml:28: ReferenceError: Can't find variable: mouse

review: Needs Fixing
Revision history for this message
Olivier Tilloy (osomon) wrote :

> Also it is a known issue that when hovering a result that has its label cut
> will expand the text over the rectangle that indicates the selection. It is
> not very pretty and we will devise a solution for that later.

That looks quite ugly indeed. Wouldn’t it be better, as a temporary measure, to never expand the label? The text would always remain cut beyond the first two lines, but that hopefully doesn’t affect usability much (tested in French, most applications’ names don’t go beyond two lines of text).

Revision history for this message
Olivier Tilloy (osomon) wrote :

> > Also it is a known issue that when hovering a result that has its label cut
> > will expand the text over the rectangle that indicates the selection. It is
> > not very pretty and we will devise a solution for that later.
>
> That looks quite ugly indeed. Wouldn’t it be better, as a temporary measure,
> to never expand the label? The text would always remain cut beyond the first
> two lines, but that hopefully doesn’t affect usability much (tested in French,
> most applications’ names don’t go beyond two lines of text).

Another solution is to fix the selection rectangle so that it outlines only the icon, excluding the text, like it does in unity.

Revision history for this message
Florian Boucault (fboucault) wrote :

> > > Also it is a known issue that when hovering a result that has its label
> cut
> > > will expand the text over the rectangle that indicates the selection. It
> is
> > > not very pretty and we will devise a solution for that later.
> >
> > That looks quite ugly indeed. Wouldn’t it be better, as a temporary measure,
> > to never expand the label? The text would always remain cut beyond the first
> > two lines, but that hopefully doesn’t affect usability much (tested in
> French,
> > most applications’ names don’t go beyond two lines of text).
>
> Another solution is to fix the selection rectangle so that it outlines only
> the icon, excluding the text, like it does in unity.

Agreed, let's do that separately.

Revision history for this message
Florian Boucault (fboucault) wrote :

> > Also it is a known issue that when hovering a result that has its label cut
> > will expand the text over the rectangle that indicates the selection. It is
> > not very pretty and we will devise a solution for that later.
>
> That looks quite ugly indeed. Wouldn’t it be better, as a temporary measure,
> to never expand the label? The text would always remain cut beyond the first
> two lines, but that hopefully doesn’t affect usability much (tested in French,
> most applications’ names don’t go beyond two lines of text).

I'd like to keep that way for other reasons such as making it a bug fix for next week rather than an added feature (expanding on hover).

Revision history for this message
Florian Boucault (fboucault) wrote :

> When I open the home page of the dash, I get 8 times the following warning:
>
> unity-2d-places: [WARNING] file:///…/places/TextMultiLine.qml:28:
> ReferenceError: Can't find variable: mouse

Fixed. Very sorry about that.

521. By Florian Boucault

Removed unused and broken code.

Revision history for this message
Olivier Tilloy (osomon) wrote :

> I'd like to keep that way for other reasons such as making it a bug fix for
> next week rather than an added feature (expanding on hover).

Ok, then it’s good to go!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches