unity-js-scopes

Merge lp://qastaging/~fboucault/unity-js-scopes/crossbuild_fixes into lp://qastaging/unity-js-scopes

  1. crossbuild_fixes
  2. Merge into trunk
Proposed by Florian Boucault
Status: Needs review
Proposed branch: lp://qastaging/~fboucault/unity-js-scopes/crossbuild_fixes
Merge into: lp://qastaging/unity-js-scopes
Diff against target: 30 lines (+5/-3)
2 files modified
debian/control (+2/-3)
debian/rules (+3/-0)
To merge this branch: bzr merge lp://qastaging/~fboucault/unity-js-scopes/crossbuild_fixes
Reviewer Review Type Date Requested Status
unity-api-1-bot continuous-integration Approve
WebApps Pending
Review via email: mp+300523@code.qastaging.launchpad.net

Commit message

Crossbuilding fixes.

Description of the change

Crossbuilding fixes.

To post a comment you must log in.
Revision history for this message
David Barth (dbarth) wrote :

I think you need to keep the g++ build-dep, as the launcher is built on top of nodejs which is pulled and compiled during the build process.

Reply
Revision history for this message
Florian Boucault (fboucault) wrote :

I think it is pulled anyway

Le mer. 20 juil. 2016 10:11, David Barth <email address hidden> a
écrit :

> I think you need to keep the g++ build-dep, as the launcher is built on
> top of nodejs which is pulled and compiled during the build process.
> --
>
> https://code.launchpad.net/~fboucault/unity-js-scopes/crossbuild_fixes/+merge/300523
> You are the owner of lp:~fboucault/unity-js-scopes/crossbuild_fixes.
>

Reply
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:143
https://jenkins.canonical.com/unity-api-1/job/lp-unity-js-scopes-ci/13/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/226
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/234
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=vivid+overlay/176
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=xenial+overlay/176
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-1-sourcepkg/release=yakkety/176
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/105
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/105/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/105
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/105/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/105
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/105/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/105
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/105/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/105
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/105/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/105
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/105/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/105
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/105/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/105
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/105/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/105
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/105/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-unity-js-scopes-ci/13/rebuild

review: Approve (continuous-integration)
Reply

Unmerged revisions

143. By Florian Boucault

Crossbuilding fixes.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: