webbrowser-app

Merge lp://qastaging/~fboucault/webbrowser-app/save_window_size into lp://qastaging/webbrowser-app/staging

  1. save_window_size
  2. Merge into staging
Proposed by Florian Boucault
Status: Merged
Merged at revision: 1620
Proposed branch: lp://qastaging/~fboucault/webbrowser-app/save_window_size
Merge into: lp://qastaging/webbrowser-app/staging
Diff against target: 34 lines (+10/-4)
1 file modified
src/app/webbrowser/webbrowser-app.qml (+10/-4)
To merge this branch: bzr merge lp://qastaging/~fboucault/webbrowser-app/save_window_size
Reviewer Review Type Date Requested Status
Olivier Tilloy Approve
Review via email: mp+317467@code.qastaging.launchpad.net

Commit message

Store and restore on startup the size of each window.

Description of the change

Store and restore on startup the size of each window.

To post a comment you must log in.
Revision history for this message
Olivier Tilloy (osomon) wrote :

Wouldn’t it be better to pass width and height as properties to windowFactory.createObject(…) in restoreWindowState(), instead of setting the properties after the window is created?

lp://qastaging/~fboucault/webbrowser-app/save_window_size updated
1610. By Florian Boucault

Merged from staging

1611. By Florian Boucault

Pass width/height at Window creation time.

Revision history for this message
Olivier Tilloy (osomon) wrote :

LGTM, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches