Merge lp://qastaging/~fboucault/webbrowser-app/switch_to_parent_tab_on_close into lp://qastaging/webbrowser-app/staging
Proposed by
Florian Boucault
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~fboucault/webbrowser-app/switch_to_parent_tab_on_close |
| Merge into: | lp://qastaging/webbrowser-app/staging |
| Diff against target: |
388 lines (+140/-58) 11 files modified
src/app/webbrowser/Browser.qml (+12/-2) src/app/webbrowser/BrowserTab.qml (+1/-0) src/app/webbrowser/TabComponent.qml (+10/-5) src/app/webbrowser/tabs-model.cpp (+16/-0) src/app/webbrowser/tabs-model.h (+1/-0) tests/autopilot/webbrowser_app/tests/__init__.py (+10/-0) tests/autopilot/webbrowser_app/tests/http_server.py (+6/-0) tests/autopilot/webbrowser_app/tests/test_new_tab_view.py (+5/-34) tests/autopilot/webbrowser_app/tests/test_site_previews.py (+0/-9) tests/autopilot/webbrowser_app/tests/test_tabs.py (+65/-8) tests/unittests/tabs-model/tst_TabsModelTests.cpp (+14/-0) |
| To merge this branch: | bzr merge lp://qastaging/~fboucault/webbrowser-app/switch_to_parent_tab_on_close |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Olivier Tilloy | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Restore focus on parent tab when closing child tab
Description of the change
Restore focus on parent tab when closing child tab
To post a comment you must log in.
Revision history for this message
| Florian Boucault (fboucault) wrote | # |
Unmerged revisions
- 1624. By Florian Boucault
-
Fixed flake8
- 1623. By Florian Boucault
-
Added corresponding AP tests
- 1622. By Florian Boucault
-
Restore focus on parent tab when closing child tab
- 1621. By Florian Boucault
-
AP test: simplified tab closing
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
flake8 unit test is failing.