webbrowser-app

Merge lp://qastaging/~fboucault/webbrowser-app/workaround_new_tab_never_unloaded into lp://qastaging/webbrowser-app/staging

  1. workaround_new_tab_never_unloaded
  2. Merge into staging
Proposed by Florian Boucault
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 1610
Merged at revision: 1615
Proposed branch: lp://qastaging/~fboucault/webbrowser-app/workaround_new_tab_never_unloaded
Merge into: lp://qastaging/webbrowser-app/staging
Diff against target: 92 lines (+29/-17)
2 files modified
src/app/webbrowser/Browser.qml (+28/-17)
src/app/webbrowser/BrowserTab.qml (+1/-0)
To merge this branch: bzr merge lp://qastaging/~fboucault/webbrowser-app/workaround_new_tab_never_unloaded
Reviewer Review Type Date Requested Status
Olivier Tilloy Approve
Review via email: mp+317113@code.qastaging.launchpad.net

Commit message

Fix issue with new tab page sometimes never being unloaded

Description of the change

Fix issue with new tab page sometimes never being unloaded

To post a comment you must log in.
Revision history for this message
Olivier Tilloy (osomon) wrote :

This breaks webbrowser_app.tests.test_new_tab_view.TestNewTabViewLifetime.test_new_tab_view_is_shared_between_tabs

review: Needs Fixing
lp://qastaging/~fboucault/webbrowser-app/workaround_new_tab_never_unloaded updated
1607. By Florian Boucault

Merged staging

1608. By Florian Boucault

Fix AP test webbrowser_app.tests.test_new_tab_view.TestNewTabViewLifetime.test_new_tab_view_is_shared_between_tabs

1609. By Florian Boucault

Clarified and centralised showing empty tab logic.

1610. By Florian Boucault

BrowserTab: made empty property readonly

Revision history for this message
Olivier Tilloy (osomon) wrote :

LGTM, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches