Linaro Image Tools

Merge lp://qastaging/~fboudra/linaro-image-tools/highlight into lp://qastaging/linaro-image-tools/11.11

  1. highlight
  2. Merge into trunk
Proposed by Fathi Boudra
Status: Rejected
Rejected by: Данило Шеган
Proposed branch: lp://qastaging/~fboudra/linaro-image-tools/highlight
Merge into: lp://qastaging/linaro-image-tools/11.11
Diff against target: 41 lines (+7/-5)
1 file modified
linaro_image_tools/media_create/check_device.py (+7/-5)
To merge this branch: bzr merge lp://qastaging/~fboudra/linaro-image-tools/highlight
Reviewer Review Type Date Requested Status
Loïc Minier (community) Needs Fixing
Review via email: mp+76522@code.qastaging.launchpad.net

Description of the change

Highlight selected device so that it's easier to read the partition/device list.
Thanks to Zygmunt Krynicki.

To post a comment you must log in.
Revision history for this message
Mattias Backman (mabac) wrote :

Salgado made a couple of suggestions in
https://code.launchpad.net/~zkrynicki/linaro-image-tools/hacking/+merge/49615,
which I think should be considered.

As for the width of the Selected column, it could either be made
wider, or perhaps leave it without a heading and just have like a 4
char arrow.

Thanks,

Mattias

Revision history for this message
Loïc Minier (lool) wrote :

Adjusting mp state

review: Needs Fixing
Revision history for this message
Данило Шеган (danilo) wrote :

No activity for quite some time, rejecting. Please resubmit if you want to work on this some more.

Unmerged revisions

434. By Fathi Boudra

Highlight selected device so that it's easier to read the partition/device list.
Thanks to Zygmunt Krynicki.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches