Merge lp://qastaging/~fboudra/linaro-image-tools/initial-arndale-bl1-support into lp://qastaging/linaro-image-tools/11.11
Proposed by
Fathi Boudra
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Fathi Boudra | ||||||||
Approved revision: | 605 | ||||||||
Merged at revision: | 600 | ||||||||
Proposed branch: | lp://qastaging/~fboudra/linaro-image-tools/initial-arndale-bl1-support | ||||||||
Merge into: | lp://qastaging/linaro-image-tools/11.11 | ||||||||
Diff against target: |
263 lines (+171/-31) 2 files modified
linaro_image_tools/media_create/boards.py (+103/-31) linaro_image_tools/media_create/tests/test_media_create.py (+68/-0) |
||||||||
To merge this branch: | bzr merge lp://qastaging/~fboudra/linaro-image-tools/initial-arndale-bl1-support | ||||||||
Related bugs: |
|
||||||||
Related blueprints: |
CI bring up: Arndale
(Essential)
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Milo Casagrande (community) | Approve | ||
Fathi Boudra | Needs Resubmitting | ||
Georgy Redkozubov | Pending | ||
Review via email: mp+143023@code.qastaging.launchpad.net |
Description of the change
* Initial support for Arndale BL1 binary (samsung_bl0_*)
It assumes a pre-defined binary file. Long term, it should be a set of new keys to add in Arndale hardware pack configuration.
* Add ethact/ethaddr to Arndale boot_env (LP: #1097265)
Arndale board doesn't have a MAC address. To get network working out of the box, we define one in U-Boot environment.
To post a comment you must log in.
The first part of the merge is similar if not identical to the previous one.
A couple of remarks: boot_files_ v2 and get_boot_env)
- We need some tests for the new board, and the overridden methods (_make_
One thing I'm not so sure about:
81 class ArndaleConfig( SamsungConfig) : nfig, self).__init__() arndale/ arndale- bl1.bin' _flavor = 'arndale' part_offset = 1 bl0_start = 1 bl0_len = 16 bl1_start = 17 bl1_len = 32 bl2_start = 49 bl2_len = 1024 env_start = 1073 env_len = 32 serial_ options = 'console= %s,115200n8'
82 def __init__(self):
83 super(ArndaleCo
84 + self.bl0_file = 'lib/firmware/
85 self.boot_script = 'boot.scr'
86 self.bootloader
87 self.dtb_addr = '0x41f00000'
88 @@ -1572,12 +1584,84 @@
89 self.load_addr = '0x40008000'
90 self.mmc_option = '0:2'
91 self.mmc_
92 + self.samsung_
93 + self.samsung_
94 self.samsung_
95 + self.samsung_
96 self.samsung_
97 + self.samsung_
98 self.samsung_
99 + self.samsung_
100 self.serial_tty = 'ttySAC2'
101 self._extra_
I guess there will be a hwpack config file, used to generate the hwpack and the corresponding metadata. serial_ options where done for hwpack format 1.0 compatibility and backward- compatibility. I think we should avoid them with newly defined config and with hwpack 3.0 format. What I would do, is define only the necessary fields that are not present in the hwpack v3.0 definition (even if it wouldn't be that hard to introduce them). So, all the samsung_* defined fields, load_addr, dtb_addr, ..., move them in the hwpack config file, keep only the bare minimum in the class and define only the overridden methods.
All the serial_tty and _extra_