Linaro Image Tools

Merge lp://qastaging/~fboudra/linaro-image-tools/initial-fedora-support into lp://qastaging/linaro-image-tools/11.11

initial-fedora-support
Merge into trunk

Proposed by Fathi Boudra on 2013-08-16

Status:	Merged
Approved by:	Fathi Boudra on 2013-08-17
Approved revision:	636
Merged at revision:	637
Proposed branch:	lp://qastaging/~fboudra/linaro-image-tools/initial-fedora-support
Merge into:	lp://qastaging/linaro-image-tools/11.11
Diff against target:	266 lines (+91/-27) 7 files modified linaro-hwpack-install (+43/-8) linaro-media-create (+19/-7) linaro_image_tools/media_create/chroot_utils.py (+1/-1) linaro_image_tools/media_create/rootfs.py (+11/-8) linaro_image_tools/media_create/tests/test_media_create.py (+2/-1) linaro_image_tools/media_create/unpack_binary_tarball.py (+4/-1) linaro_image_tools/utils.py (+11/-1)
To merge this branch:	bzr merge lp://qastaging/~fboudra/linaro-image-tools/initial-fedora-support
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Fathi Boudra		Approve on 2013-08-17
Milo Casagrande (community)	2013-08-16	Needs Fixing on 2013-08-16
Review via email: mp+180492@code.qastaging.launchpad.net

Description of the change

Add initial support for Fedora rootfs

Revision history for this message

Milo Casagrande (milo) wrote on 2013-08-16:

Fathi,

thanks for working on this. As initial support it looks good to go to me.

review: Approve

Revision history for this message

Milo Casagrande (milo) wrote on 2013-08-16:

Spoke too fast... didn't wait for the tests to finish.
The code itself is good to go, there is one test failing though:

linaro_image_tools.media_create.tests.test_media_create.TestPopulateRootFS.test_populate_rootfs

Would be better to fix that as well.

review: Needs Fixing

lp://qastaging/~fboudra/linaro-image-tools/initial-fedora-support updated on 2013-08-17

636. By Fathi Boudra on 2013-08-17: Fix populate rootfs test

Revision history for this message

Fathi Boudra (fboudra) wrote on 2013-08-17:

Thanks Milo. Test fixed and test suite passed:
running=python -m subunit.run linaro_image_tools.tests.test_suite
Ran 853 tests in 8.896s (-1.147s)
PASSED (id=1)

review: Approve