Merge lp://qastaging/~fgimenez/snapcraft/build-examples-test into lp://qastaging/~snappy-dev/snapcraft/core

Thanks, this is a good start, looping over everything in examples will do the initial trick. In the future I will split this out a bit and use something a bit more custom for each checking if stage and snap have the right set of files for example.

The reason I set to needs fixing though is because of 'run_examples_tests.sh', it seems there is too much duplicate code here and in runtests.sh, it also introduces one more driver for them.

I'd like to see this at least driven by an envvar or command arg

./runtests.sh all (default)
./runtests.sh unit
./runtest.sh plainbox
./runtest.sh plainbox examples|normal

Thoughts?

I agree with what sergio says. I'd also like to see snapcraft run on each example, and check that it does what it's supposed to. That's way more complex and I have no idea yet how to do it, so +1 to this branch that gets all started.

fwiw, I did a little refactor in here to support dep8:
https://code.launchpad.net/~elopio/snapcraft/dep8/+merge/266998

You could put the script inside examples dir.

Thanks Federico.

Thanks a lot Sergio and Leo for your comments.

With the latest changes it can be invoked with the options suggested by Sergio, by default it only runs the normal test plan in plainbox, to run the examples test plan you have to be explicit:

./runtests.sh plainbox examples

Let me know what do you think. Leo, your dep8 work is already merged, right?

I think the following changes would be good: http://pastebin.ubuntu.com/12448355/

Unfortunately does the runexamples test still explode: http://pastebin.ubuntu.com/12448397/

And yep, the dep8 branch is in trunk.

Back to wip, autopkgtest not yet working

It should be fixed now, the examples folder was not being added to the deb and because of that was not available in the testbed, let me know if it works for you.

Great work.

As discussed during the standup, can we have a snapcraft-examples binary package that depends on the snapcraft binary package?

+Tests: runtests
+ runexamples

I would call them integration-tests and example-tests, or something like that.

I ran the tests, and they work. Got one failure, which is awesome. Thanks Federico!

Waiting for the examples package to approve.

https://code.launchpad.net/~dholbach/snapcraft/snapcraft-examples/+merge/271838

Can you apply the following change?

== modified file 'examples/downloader-with-wiki-parts/snapcraft.yaml'
--- examples/downloader-with-wiki-parts/snapcraft.yaml 2015-09-21 05:04:31 +0000
+++ examples/downloader-with-wiki-parts/snapcraft.yaml 2015-09-22 08:11:03 +0000
@@ -14,3 +14,4 @@
         source: .
         after:
             - curl
+build-packages: [libssl-dev]

@Daniel, thanks, done :)

Thanks a lot! Good work!

There is one lintian error. Fixed with:
http://paste.ubuntu.com/12523307/

Lets land this one, the lintian fix is here: https://code.launchpad.net/~elopio/snapcraft/fix_lintian/+merge/272023