Merge lp://qastaging/~fgimenez/snappy-hub/snappy-examples-nitpicks into lp://qastaging/~snappy-dev/snappy-hub/snappy-examples

Proposed by Federico Gimenez
Status: Merged
Merged at revision: 81
Proposed branch: lp://qastaging/~fgimenez/snappy-hub/snappy-examples-nitpicks
Merge into: lp://qastaging/~snappy-dev/snappy-hub/snappy-examples
Diff against target: 195 lines (+56/-55)
7 files modified
config-example-bash/bin/hello (+1/-1)
config-example-bash/meta/readme.md (+1/-1)
config-example/bin/hello (+1/-1)
config-example/meta/hooks/config (+23/-22)
config-example/meta/readme.md (+1/-1)
python-xkcd-webserver/bin/xkcd-webserver (+28/-28)
python-xkcd-webserver/meta/package.yaml (+1/-1)
To merge this branch: bzr merge lp://qastaging/~fgimenez/snappy-hub/snappy-examples-nitpicks
Reviewer Review Type Date Requested Status
Snappy Developers Pending
Review via email: mp+260547@code.qastaging.launchpad.net

Commit message

Some doc nitpicks, flake8 fixes and a service start binary path fix.

Description of the change

Some doc nitpicks, flake8 fixes and a service start binary path fix.

Regarding the service binary path, without specifying the './' at the beginning of the path the snap was being installed, the service was started, but on reboot the service process wasn't there anymore and the snappy list command gave an empty entry for the service snap (btw, is this the expected behaviour? running in rolling/edge).
I've taken the fix from the config of go-example-webserver, which works properly on reboot.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches