jenkins-launchpad-plugin

Merge lp://qastaging/~fginther/jenkins-launchpad-plugin/jenkins-token into lp://qastaging/~private-ps-quality-team/jenkins-launchpad-plugin/trunk

  1. jenkins-token
  2. Merge into trunk
Proposed by Francis Ginther
Status: Merged
Approved by: Francis Ginther
Approved revision: 124
Merged at revision: 124
Proposed branch: lp://qastaging/~fginther/jenkins-launchpad-plugin/jenkins-token
Merge into: lp://qastaging/~private-ps-quality-team/jenkins-launchpad-plugin/trunk
Diff against target: 81 lines (+41/-3)
3 files modified
jlp.config (+3/-0)
jlp/jenkinsutils.py (+4/-2)
tests/test_jenkinsutils.py (+34/-1)
To merge this branch: bzr merge lp://qastaging/~fginther/jenkins-launchpad-plugin/jenkins-token
Reviewer Review Type Date Requested Status
Vincent Ladeuil (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+196396@code.qastaging.launchpad.net

Commit message

Add a jenkins_build_token config parameter to allow triggering of jenkins jobs through the script trigger on newer versions of jenkins.

Description of the change

Add a jenkins_build_token config parameter to allow triggering of jenkins jobs through the script trigger on newer versions of jenkins.

To post a comment you must log in.
lp://qastaging/~fginther/jenkins-launchpad-plugin/jenkins-token updated
124. By Francis Ginther

Fix pep8 error.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:124
http://jenkins.qa.ubuntu.com/job/jenkins-launchpad-plugin-ci/31/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/jenkins-launchpad-plugin-saucy-amd64-ci/33

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/jenkins-launchpad-plugin-ci/31/rebuild

review: Approve (continuous-integration)
Revision history for this message
Vincent Ladeuil (vila) wrote :

Nice ! Cover letter + tests make reviews easy \o/

Only a few style suggestions if you care about them:

47 + '''Verify that the default jenkins_build_token value results in a
48 + token parameter of None being passed to jenkins.build_job API.'''

Test docstrings are used by some test runners under the assumption that the first line is short enough (<80 chars) and can be used to document the test purpose.

You can give a longer description when needed after an empty line.

I.e.:

'''No token sent if empty.

Verify that the default jenkins_build_token value results in a
token parameter of None being passed to jenkins.build_job API.
'''

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: