Ubuntu CI Services

Merge lp://qastaging/~fginther/ubuntu-ci-services-itself/lander-pass-master-ppa into lp://qastaging/ubuntu-ci-services-itself

lander-pass-master-ppa
Merge into trunk

Proposed by Francis Ginther on 2014-03-11

Status:

Merged

Approved by:

Andy Doan on 2014-03-11

Approved revision:

356

Merged at revision:

361

Proposed branch:

lp://qastaging/~fginther/ubuntu-ci-services-itself/lander-pass-master-ppa

Merge into:

lp://qastaging/ubuntu-ci-services-itself

Diff against target:

20 lines (+5/-1)

1 file modified

lander/bin/lander_service_wrapper.py (+5/-1)

To merge this branch:

bzr merge lp://qastaging/~fginther/ubuntu-ci-services-itself/lander-pass-master-ppa

Critical

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2014-03-11
Francis Ginther			Needs Resubmitting on 2014-03-11
Evan (community)			Needs Fixing on 2014-03-11
Paul Larson		2014-03-11	Approve on 2014-03-11
Review via email: mp+210410@code.qastaging.launchpad.net

Commit message

Pass both the build ppa and the master ppa to the image-builder.

Description of the change

Pass both the build ppa and the master ppa to the image-builder.

Revision history for this message

Paul Larson (pwlars) wrote on 2014-03-11:

Looks good, +1

review: Approve

Revision history for this message

Evan (ev) wrote on 2014-03-11:

% pyflakes lander/bin/lander_service_wrapper.py
lander/bin/lander_service_wrapper.py:259: invalid syntax
'archive': request_parameters['master_ppa'],
^

review: Needs Fixing

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-03-11:

FAILED: Continuous integration, rev:355
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/371/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/371/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~fginther/ubuntu-ci-services-itself/lander-pass-master-ppa updated on 2014-03-11

356. By Francis Ginther on 2014-03-11: Fix copy and paste mistake going from dict to list.

Revision history for this message

Francis Ginther (fginther) wrote on 2014-03-11:

> % pyflakes lander/bin/lander_service_wrapper.py
> lander/bin/lander_service_wrapper.py:259: invalid syntax
> 'archive': request_parameters['master_ppa'],
> ^

head -> desk

Fixed.

review: Needs Resubmitting

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-03-11:

PASSED: Continuous integration, rev:356
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/373/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/373/rebuild