Ubuntu Test Cases

Merge lp://qastaging/~fginther/ubuntu-test-cases/flash-retry into lp://qastaging/ubuntu-test-cases/touch

  1. flash-retry
  2. Merge into touch
Proposed by Francis Ginther
Status: Merged
Approved by: Francis Ginther
Approved revision: 327
Merged at revision: 334
Proposed branch: lp://qastaging/~fginther/ubuntu-test-cases/flash-retry
Merge into: lp://qastaging/ubuntu-test-cases/touch
Diff against target: 63 lines (+41/-5)
1 file modified
scripts/provision.sh (+41/-5)
To merge this branch: bzr merge lp://qastaging/~fginther/ubuntu-test-cases/flash-retry
Reviewer Review Type Date Requested Status
Paul Larson Approve
Review via email: mp+239930@code.qastaging.launchpad.net

Commit message

Add retries when entering the bootloader and flashing the device. This required setting ANDROID_SERIAL if it wasn't specified.

Description of the change

Add retries when entering the bootloader and flashing the device. This required setting ANDROID_SERIAL if it wasn't specified.

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

Thanks for doing this, it certainly needs to be done. We unfortunately can't trust that ubuntu-device-flash will always do something sane, and we should certain give it a couple of retries. A couple of minor comments below.

review: Needs Fixing
lp://qastaging/~fginther/ubuntu-test-cases/flash-retry updated
325. By Francis Ginther

Remove attempts to guess at the adb device and require to enable the reboot-bootloader retries. Add some context around the reboot-bootloader retry logic and the retry wait durations.

Revision history for this message
Francis Ginther (fginther) wrote :

Paul, I've addressed your comments and add some context for the retry logic.

Revision history for this message
Francis Ginther (fginther) wrote :

I haven't had a chance to test this yet, please don't top-approve!

Revision history for this message
Francis Ginther (fginther) wrote :

Tested now, a successful case without need for retries worked.

Revision history for this message
Paul Larson (pwlars) wrote :

Ok, one minor question, otherwise I think this looks good. And thanks for testing!

review: Approve
lp://qastaging/~fginther/ubuntu-test-cases/flash-retry updated
326. By Francis Ginther

${ANDROID_SERIAL} needs to be wrapped in double quotes.

Revision history for this message
Francis Ginther (fginther) wrote :

Oops, need to quote "${ANDROID_SERIAL}".

Revision history for this message
Francis Ginther (fginther) wrote :

Respond to Pauls' question.

Revision history for this message
Paul Larson (pwlars) wrote :

weird scenario, thanks for hunting this down!

review: Approve
lp://qastaging/~fginther/ubuntu-test-cases/flash-retry updated
327. By Francis Ginther

Add reboot-bootloader bug to comment in the workaround.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches