Xubuntu Documentation

Merge lp://qastaging/~flocculant/xubuntu-docs/cont1704 into lp://qastaging/xubuntu-docs/zesty

  1. cont1704
  2. Merge into zesty
Proposed by Kev Bowring
Status: Merged
Approved by: Pasi Lallinaho
Approved revision: 629
Merged at revision: 628
Proposed branch: lp://qastaging/~flocculant/xubuntu-docs/cont1704
Merge into: lp://qastaging/xubuntu-docs/zesty
Diff against target: 428 lines (+70/-68)
10 files modified
contributor-docs/C/common-reference.xml (+0/-1)
contributor-docs/C/development.xml (+2/-3)
contributor-docs/C/documentation.xml (+20/-17)
contributor-docs/C/getting-started.xml (+3/-3)
contributor-docs/C/index.xml (+1/-1)
contributor-docs/C/processes-release-cycle.xml (+5/-6)
contributor-docs/C/qa-bugs.xml (+10/-9)
contributor-docs/C/qa-team.xml (+8/-12)
contributor-docs/C/qa-tester.xml (+12/-9)
contributor-docs/C/qa-testing.xml (+9/-7)
To merge this branch: bzr merge lp://qastaging/~flocculant/xubuntu-docs/cont1704
Reviewer Review Type Date Requested Status
David Pires Needs Fixing
Pasi Lallinaho (community) Needs Fixing
Review via email: mp+315620@code.qastaging.launchpad.net

Description of the change

Most changes are self-explanatory.

QA pages - important to remove references to Trello.

Documentation:

Currently we have in the translate section - only exist in xubuntu, mainly built for xubuntu, essential for xubuntu.

Suggest changing the order to exist, essential, mainly.

Additionally - lightdm greeter settings in in essential, greeter is in mainly - suggest swapping these around - greeter being more essential than settings for it.

light-locker settings no longer exists in xubuntu - that now all being part of xfce power manager

To post a comment you must log in.
Revision history for this message
Pasi Lallinaho (knome) wrote :

General direction and changes are OK; see some minor comments on the formatting inline.

review: Needs Fixing
Revision history for this message
Pasi Lallinaho (knome) :
Revision history for this message
Kev Bowring (flocculant) wrote :

some changed locally as per in-line

Revision history for this message
David Pires (slickymaster) wrote :

The overall changes are OK. Don't see any issues with the order change of the packages to be translated nor with the swapping of the LightDM Greeter Settings with the LightDM Greeter.

Light Locker Settings and the references to Trello really had to go.

There are still some minor issues, which I commented inline, that should be fixed. But apart from those and if no team members oppose I can merge this.

review: Needs Fixing
Revision history for this message
Kev Bowring (flocculant) wrote :

see inline comments.

Revision history for this message
David Pires (slickymaster) wrote :

Inline proposal to use 'ISOs' and 'PPAs' instead of 'ISO's' and 'PPA's', in accordance to the Oxford Dictionaries Online rule.

lp://qastaging/~flocculant/xubuntu-docs/cont1704 updated
629. By Kev Bowring

Changes as per review

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches