OpenERP Community Backports (Addons)

Merge lp://qastaging/~florian-dacosta/ocb-addons/6.1_purchase_line_partner_fix into lp://qastaging/ocb-addons/6.1

  1. 6.1_purchase_line_partner_fix
  2. Merge into 6.1
Proposed by Florian da Costa
Status: Work in progress
Proposed branch: lp://qastaging/~florian-dacosta/ocb-addons/6.1_purchase_line_partner_fix
Merge into: lp://qastaging/ocb-addons/6.1
Diff against target: 28 lines (+10/-1)
1 file modified
purchase/purchase.py (+10/-1)
To merge this branch: bzr merge lp://qastaging/~florian-dacosta/ocb-addons/6.1_purchase_line_partner_fix
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp Needs Fixing
Holger Brunn (Therp) code review Needs Fixing
Review via email: mp+185327@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

Please make _update_partner_from_purchase being able to cope with multiple ids (it only returns the last PO's order lines), something like

res += purchase['order_line']

in #12

review: Needs Fixing (code review)
Reply
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Same comments than: https://code.launchpad.net/~florian-dacosta/ocb-addons/7.0_purchase_line_partner_fix/+merge/185331/comments/449347 :

l.11 The context must be propagated in the read.
l.24 No mutable in keyword argument: replace "c={}" by "c=None".

l.23-24 Indentation is dubious, see http://www.python.org/dev/peps/pep-0008/#indentation

review: Needs Fixing
Reply
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Setting to WIP after 3 months of inactivity.

Reply

Unmerged revisions

6788. By Florian da Costa

[FIX] Add function to recalculate the related field partner_id of purchase_order_line because it would not update when the purchase order's partner_id is updated

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches